Merge pull request #1406 from tanhuaan/main

refactor: use slices.Contains to simplify code

util/sprig/defaults.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"reflect"
+	"slices"
 	"strings"
 )
 
@@ -95,12 +96,7 @@ func coalesce(v ...any) any {
 // Returns:
 //   - bool: True if all values are non-empty, false otherwise
 func all(v ...any) bool {
-	for _, val := range v {
+	return !slices.ContainsFunc(v, empty)
-		if empty(val) {
-			return false
-		}
-	}
-	return true
 }
 
 // anyNonEmpty checks if at least one value in a list is non-empty.

util/util.go

@@ -12,6 +12,7 @@ import (
 	"net/netip"
 	"os"
 	"regexp"
+	"slices"
 	"strconv"
 	"strings"
 	"sync"
@@ -49,12 +50,7 @@ func FileExists(filename string) bool {
 
 // Contains returns true if needle is contained in haystack
 func Contains[T comparable](haystack []T, needle T) bool {
-	for _, s := range haystack {
+	return slices.Contains(haystack, needle)
-		if s == needle {
-			return true
-		}
-	}
-	return false
 }
 
 // ContainsIP returns true if any one of the of prefixes contains the ip.