Make manual eslint fixes

These are safe fixes, more complicated fixes can be done separately
(just disabled those errors for now).

- Reorder declarations to fix `no-use-before-define`
- Rename parameters for `no-shadow`
- Remove unused parameters, functions, imports
- Switch from `++` and `—` to `+= 1` and `-= 1` for `no-unary`
- Use object spreading instead of parameter reassignment in auth utils
- Use `window.location` instead of `location` global
- Use inline JSX strings instead of unescaped values
-

web/src/app/errors.js

@@ -1,37 +1,6 @@
+/* eslint-disable max-classes-per-file */
 // This is a subset of, and the counterpart to errors.go
 
-export const fetchOrThrow = async (url, options) => {
-  const response = await fetch(url, options);
-  if (response.status !== 200) {
-    await throwAppError(response);
-  }
-  return response; // Promise!
-};
-
-export const throwAppError = async (response) => {
-  if (response.status === 401 || response.status === 403) {
-    console.log(`[Error] HTTP ${response.status}`, response);
-    throw new UnauthorizedError();
-  }
-  const error = await maybeToJson(response);
-  if (error?.code) {
-    console.log(`[Error] HTTP ${response.status}, ntfy error ${error.code}: ${error.error || ""}`, response);
-    if (error.code === UserExistsError.CODE) {
-      throw new UserExistsError();
-    } else if (error.code === TopicReservedError.CODE) {
-      throw new TopicReservedError();
-    } else if (error.code === AccountCreateLimitReachedError.CODE) {
-      throw new AccountCreateLimitReachedError();
-    } else if (error.code === IncorrectPasswordError.CODE) {
-      throw new IncorrectPasswordError();
-    } else if (error?.error) {
-      throw new Error(`Error ${error.code}: ${error.error}`);
-    }
-  }
-  console.log(`[Error] HTTP ${response.status}, not a ntfy error`, response);
-  throw new Error(`Unexpected response ${response.status}`);
-};
-
 const maybeToJson = async (response) => {
   try {
     return await response.json();
@@ -77,3 +46,35 @@ export class IncorrectPasswordError extends Error {
     super("Password incorrect");
   }
 }
+
+export const throwAppError = async (response) => {
+  if (response.status === 401 || response.status === 403) {
+    console.log(`[Error] HTTP ${response.status}`, response);
+    throw new UnauthorizedError();
+  }
+  const error = await maybeToJson(response);
+  if (error?.code) {
+    console.log(`[Error] HTTP ${response.status}, ntfy error ${error.code}: ${error.error || ""}`, response);
+    if (error.code === UserExistsError.CODE) {
+      throw new UserExistsError();
+    } else if (error.code === TopicReservedError.CODE) {
+      throw new TopicReservedError();
+    } else if (error.code === AccountCreateLimitReachedError.CODE) {
+      throw new AccountCreateLimitReachedError();
+    } else if (error.code === IncorrectPasswordError.CODE) {
+      throw new IncorrectPasswordError();
+    } else if (error?.error) {
+      throw new Error(`Error ${error.code}: ${error.error}`);
+    }
+  }
+  console.log(`[Error] HTTP ${response.status}, not a ntfy error`, response);
+  throw new Error(`Unexpected response ${response.status}`);
+};
+
+export const fetchOrThrow = async (url, options) => {
+  const response = await fetch(url, options);
+  if (response.status !== 200) {
+    await throwAppError(response);
+  }
+  return response; // Promise!
+};