dearsky/ntfy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix server crash (nil pointer panic) when subscriber disconnects during publish

Browse Source
This commit is contained in:
binwiederhier
2026-02-08 11:23:31 -05:00
parent 3647d3975c
commit 65050ef4dc
3 changed files with 135 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server/server.go
View File

@@ -1463,7 +1463,8 @@ func (s *Server) handleSubscribeHTTP(w http.ResponseWriter, r *http.Request, v *
// This blocks until any in-flight sub() call finishes writing/flushing the response writer,
// then marks the connection as closed so future sub() calls are no-ops. This prevents a panic
// from writing to a response writer that has been cleaned up after the handler returns.
// See https://github.com/binwiederhier/ntfy/issues/338#issuecomment-1163425889.
// See https://github.com/binwiederhier/ntfy/issues/338#issuecomment-1163425889
// and https://github.com/binwiederhier/ntfy/pull/1598.
wlock.Lock()
closed = true
wlock.Unlock()