From 34b1d0e6df5463b68b51f44433a6b8a034fb34f8 Mon Sep 17 00:00:00 2001 From: Razvan Dimescu Date: Wed, 8 Apr 2026 05:14:58 +0300 Subject: [PATCH] test: drop windows_backup_filters_loopback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test inlined the 3-line filter block from install_windows rather than calling a production helper, so it was testing stdlib Vec::retain + is_loopback_or_stub — both already covered elsewhere. Deleting it removes a test that would silently pass even if install_windows stopped filtering altogether. The predicate logic for macOS-shaped backups stays covered by macos_backup_real_upstream_detection (same inner Vec type). Co-Authored-By: Claude Opus 4.6 (1M context) --- src/system_dns.rs | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/src/system_dns.rs b/src/system_dns.rs index 9d48996..dc0a0b1 100644 --- a/src/system_dns.rs +++ b/src/system_dns.rs @@ -1582,34 +1582,6 @@ Wireless LAN adapter Wi-Fi: assert!(!resolv_conf_is_numa_managed(mixed)); } - #[test] - fn windows_backup_filters_loopback() { - use std::collections::HashMap; - let mut interfaces: HashMap = HashMap::new(); - interfaces.insert( - "Wi-Fi".into(), - WindowsInterfaceDns { - dhcp: false, - servers: vec!["127.0.0.1".into(), "1.1.1.1".into()], - }, - ); - interfaces.insert( - "Ethernet".into(), - WindowsInterfaceDns { - dhcp: true, - servers: vec!["127.0.0.1".into()], - }, - ); - - // Mimic the filter step from install_windows - for iface in interfaces.values_mut() { - iface.servers.retain(|s| !is_loopback_or_stub(s)); - } - - assert_eq!(interfaces["Wi-Fi"].servers, vec!["1.1.1.1".to_string()]); - assert!(interfaces["Ethernet"].servers.is_empty()); - } - #[test] fn parse_ipconfig_skips_disconnected() { let sample = "\