dearsky/numa
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 25 Wiki Activity

feat: distinguish UPSTREAM vs FORWARD in logs and stats #103

Merged
razvandimescu merged 3 commits from feat/upstream-log-label into main 2026-04-15 19:00:28 +08:00
Conversation 0 Commits 3 Files Changed 4 +53 -8
razvandimescu commented 2026-04-14 23:18:47 +08:00 (Migrated from github.com)
Copy Link

Summary

  • Queries matching a [[forwarding]] suffix rule keep logging as FORWARD; queries resolved via the default [upstream] pool now log as UPSTREAM. Previously both shared FORWARD, making it impossible to tell from logs whether a rule matched.
  • Adds QueryPath::Upstream, a queries.upstream counter in /stats, and matching dashboard filter / bar / tag.
  • Addresses item (3) in #102.

Test plan

  • cargo test --lib (285 pass, +1 new — pipeline_default_pool_reports_upstream_path)
  • cargo clippy --all-targets (no new warnings)
  • Smoke: start numa, query a domain that hits a [[forwarding]] rule and one that doesn't; confirm log labels differ.
  • /stats exposes queries.upstream alongside queries.forwarded.
  • Dashboard: Upstream row appears in the path chart; upstream filter works in Recent Queries.

Out of scope

Items (1), (2), (4) from #102 — tracked separately.

## Summary - Queries matching a `[[forwarding]]` suffix rule keep logging as `FORWARD`; queries resolved via the default `[upstream]` pool now log as `UPSTREAM`. Previously both shared `FORWARD`, making it impossible to tell from logs whether a rule matched. - Adds `QueryPath::Upstream`, a `queries.upstream` counter in `/stats`, and matching dashboard filter / bar / tag. - Addresses item (3) in #102. ## Test plan - [x] `cargo test --lib` (285 pass, +1 new — `pipeline_default_pool_reports_upstream_path`) - [x] `cargo clippy --all-targets` (no new warnings) - [x] Smoke: start numa, query a domain that hits a `[[forwarding]]` rule and one that doesn't; confirm log labels differ. - [x] `/stats` exposes `queries.upstream` alongside `queries.forwarded`. - [x] Dashboard: `Upstream` row appears in the path chart; `upstream` filter works in Recent Queries. ## Out of scope Items (1), (2), (4) from #102 — tracked separately.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 rust
Pull requests that update rust code
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/numa#103
Delete Branch "feat/upstream-log-label"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?