dearsky/numa
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 25 Wiki Activity

fix(packet): parse SOA natively to stop malformed replies (#128) #137

Merged
razvandimescu merged 1 commits from fix/soa-compression-roundtrip into main 2026-04-24 18:59:57 +08:00
Conversation 0 Commits 1 Files Changed 3 +206 -1
razvandimescu commented 2026-04-23 05:37:02 +08:00 (Migrated from github.com)
Copy Link

Summary

  • SOA was stored as DnsRecord::UNKNOWN (opaque rdata), so RFC 1035 §3.3.13 compression pointers in MNAME/RNAME — offsets into the upstream packet — were re-emitted verbatim. Once Numa applied its own compression, those pointers landed on garbage and clients rejected the reply ("malformed reply packet" in kdig, issue #128).
  • Parse SOA natively via read_qname and write via write_qname, mirroring the existing NS/CNAME/MX pattern. Adds the SOA arm to record_rdata_canonical for RRSIG verification.

Closes #128.

Test plan

  • cargo test — 354 lib tests + 1 new integration test pass.
  • make all (fmt + clippy + audit + test) green.
  • New regression tests/soa_compression_bug.rs — hand-rolled upstream packet (CNAME chain + compressed SOA in authority that points into answer rdata), round-trips through Numa, validated with hickory-proto strict parse.
  • Field check: confirm kdig @<numa> odin.adobe.com https no longer reports "malformed reply packet" against the affected upstream/cache combo from the issue.
## Summary - SOA was stored as `DnsRecord::UNKNOWN` (opaque rdata), so RFC 1035 §3.3.13 compression pointers in MNAME/RNAME — offsets into the *upstream* packet — were re-emitted verbatim. Once Numa applied its own compression, those pointers landed on garbage and clients rejected the reply ("malformed reply packet" in kdig, issue #128). - Parse SOA natively via `read_qname` and write via `write_qname`, mirroring the existing NS/CNAME/MX pattern. Adds the SOA arm to `record_rdata_canonical` for RRSIG verification. Closes #128. ## Test plan - [x] `cargo test` — 354 lib tests + 1 new integration test pass. - [x] `make all` (fmt + clippy + audit + test) green. - [x] New regression `tests/soa_compression_bug.rs` — hand-rolled upstream packet (CNAME chain + compressed SOA in authority that points into answer rdata), round-trips through Numa, validated with `hickory-proto` strict parse. - [ ] Field check: confirm `kdig @<numa> odin.adobe.com https` no longer reports "malformed reply packet" against the affected upstream/cache combo from the issue.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 rust
Pull requests that update rust code
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/numa#137
Delete Branch "fix/soa-compression-roundtrip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?