dearsky/numa
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 25 Wiki Activity

fix: return NXDOMAIN for .local mDNS queries #18

Merged
razvandimescu merged 1 commits from fix/local-domain-servfail into main 2026-03-29 04:42:33 +08:00
Conversation 0 Commits 1 Files Changed 1 +5 -1
razvandimescu commented 2026-03-29 01:15:46 +08:00 (Migrated from github.com)
Copy Link

Summary

  • .local is reserved for mDNS (RFC 6762) and cannot be resolved by upstream DNS servers
  • Queries like _grpc_config.localhost.local were falling through to upstream resolution, timing out (~560ms), and returning SERVFAIL
  • Added .local to is_special_use_domain() so these queries get an immediate NXDOMAIN response locally

Test plan

  • Verify dig @127.0.0.1 _grpc_config.localhost.local TXT returns NXDOMAIN (not SERVFAIL)
  • Verify .local queries no longer appear with SERVFAIL in the dashboard query log
  • Verify normal DNS resolution is unaffected
  • make all passes (fmt, clippy, audit, build, 82 tests)

🤖 Generated with Claude Code

## Summary - `.local` is reserved for mDNS (RFC 6762) and cannot be resolved by upstream DNS servers - Queries like `_grpc_config.localhost.local` were falling through to upstream resolution, timing out (~560ms), and returning SERVFAIL - Added `.local` to `is_special_use_domain()` so these queries get an immediate NXDOMAIN response locally ## Test plan - [ ] Verify `dig @127.0.0.1 _grpc_config.localhost.local TXT` returns NXDOMAIN (not SERVFAIL) - [ ] Verify `.local` queries no longer appear with SERVFAIL in the dashboard query log - [ ] Verify normal DNS resolution is unaffected - [ ] `make all` passes (fmt, clippy, audit, build, 82 tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 rust
Pull requests that update rust code
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/numa#18
Delete Branch "fix/local-domain-servfail"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?