feat(resolver): filter_aaaa for IPv4-only networks #119
10
numa.toml
10
numa.toml
@@ -8,6 +8,16 @@ api_port = 5380
|
||||
# %PROGRAMDATA%\numa on windows. Override for
|
||||
# containerized deploys or tests that can't
|
||||
# write to the system path.
|
||||
# filter_aaaa = true # on IPv4-only networks, answer AAAA queries with
|
||||
# NODATA (NOERROR + empty answer) so Happy Eyeballs
|
||||
# clients don't wait on a v6 attempt that can't
|
||||
# succeed. Also strips `ipv6hint` from HTTPS/SVCB
|
||||
# records (RFC 9460) so modern browsers (Chrome
|
||||
# ≥103, Firefox, Safari) don't bypass the AAAA
|
||||
# filter via SVCB hints. Local zones, overrides,
|
||||
# and the .numa proxy are NOT filtered — you can
|
||||
# still configure v6 records for local services.
|
||||
# Default: false.
|
||||
|
||||
# [upstream]
|
||||
# mode = "forward" # "forward" (default) — relay to upstream
|
||||
|
||||
@@ -93,6 +93,12 @@ pub struct ServerConfig {
|
||||
/// Defaults to `crate::data_dir()` (platform-specific system path) if unset.
|
||||
#[serde(default)]
|
||||
pub data_dir: Option<PathBuf>,
|
||||
/// Synthesize NODATA (NOERROR + empty answer) for AAAA queries, and
|
||||
/// strip `ipv6hint` from HTTPS/SVCB responses (RFC 9460). For IPv4-only
|
||||
/// networks where Happy Eyeballs fallback adds latency. Local zones,
|
||||
/// overrides, and the service proxy are not affected. Default false.
|
||||
#[serde(default)]
|
||||
pub filter_aaaa: bool,
|
||||
}
|
||||
|
||||
impl Default for ServerConfig {
|
||||
@@ -102,6 +108,7 @@ impl Default for ServerConfig {
|
||||
api_port: default_api_port(),
|
||||
api_bind_addr: default_api_bind_addr(),
|
||||
data_dir: None,
|
||||
filter_aaaa: false,
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -580,6 +587,17 @@ mod tests {
|
||||
assert!(config.lan.enabled);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn filter_aaaa_defaults_false() {
|
||||
assert!(!ServerConfig::default().filter_aaaa);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn filter_aaaa_parses_from_server_section() {
|
||||
let config: Config = toml::from_str("[server]\nfilter_aaaa = true").unwrap();
|
||||
assert!(config.server.filter_aaaa);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn custom_bind_addrs_parse() {
|
||||
let toml = r#"
|
||||
|
||||
230
src/ctx.rs
230
src/ctx.rs
@@ -77,6 +77,10 @@ pub struct ServerCtx {
|
||||
pub ca_pem: Option<String>,
|
||||
pub mobile_enabled: bool,
|
||||
pub mobile_port: u16,
|
||||
/// When true, AAAA queries short-circuit with NODATA (NOERROR + empty
|
||||
/// answer) instead of hitting cache/forwarding/upstream. Local data
|
||||
/// (overrides, zones, .numa proxy, blocklist sinkhole) is unaffected.
|
||||
pub filter_aaaa: bool,
|
||||
}
|
||||
|
||||
/// Transport-agnostic DNS resolution. Runs the full pipeline (overrides, blocklist,
|
||||
@@ -172,6 +176,13 @@ pub async fn resolve_query(
|
||||
60,
|
||||
));
|
||||
(resp, QueryPath::Blocked, DnssecStatus::Indeterminate)
|
||||
} else if qtype == QueryType::AAAA && ctx.filter_aaaa {
|
||||
// RFC 2308 NODATA: NOERROR with empty answer section. Prevents
|
||||
// Happy Eyeballs clients from waiting on an AAAA they'll never use
|
||||
// on IPv4-only networks. NXDOMAIN would be wrong (it'd imply the
|
||||
// name doesn't exist for A either).
|
||||
let resp = DnsPacket::response_from(&query, ResultCode::NOERROR);
|
||||
(resp, QueryPath::Local, DnssecStatus::Indeterminate)
|
||||
} else {
|
||||
let cached = ctx.cache.read().unwrap().lookup_with_status(&qname, qtype);
|
||||
if let Some((cached, cached_dnssec, freshness)) = cached {
|
||||
@@ -334,6 +345,15 @@ pub async fn resolve_query(
|
||||
strip_dnssec_records(&mut response);
|
||||
}
|
||||
|
||||
// filter_aaaa: also strip ipv6hint from HTTPS/SVCB answers so modern
|
||||
// browsers (Chrome ≥103 etc.) don't receive v6 address hints via the
|
||||
// HTTPS record path that bypasses AAAA entirely. Gated on !client_do
|
||||
// because modifying rdata invalidates any accompanying RRSIG — a DO-bit
|
||||
// validator downstream would reject the response as Bogus.
|
||||
if ctx.filter_aaaa && !client_do {
|
||||
strip_svcb_ipv6_hints(&mut response);
|
||||
}
|
||||
|
||||
// Echo EDNS back if client sent it
|
||||
if query.edns.is_some() {
|
||||
response.edns = Some(crate::packet::EdnsOpt {
|
||||
@@ -491,6 +511,21 @@ fn strip_dnssec_records(pkt: &mut DnsPacket) {
|
||||
pkt.resources.retain(|r| !is_dnssec_record(r));
|
||||
}
|
||||
|
||||
const SVCB_QTYPE: u16 = 64;
|
||||
|
||||
fn strip_svcb_ipv6_hints(pkt: &mut DnsPacket) {
|
||||
let https_qtype = QueryType::HTTPS.to_num();
|
||||
pkt.for_each_record_mut(|rec| {
|
||||
if let DnsRecord::UNKNOWN { qtype, data, .. } = rec {
|
||||
if *qtype == https_qtype || *qtype == SVCB_QTYPE {
|
||||
if let Some(new_data) = crate::svcb::strip_ipv6hint(data) {
|
||||
*data = new_data;
|
||||
}
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
fn is_special_use_domain(qname: &str) -> bool {
|
||||
if qname.ends_with(".in-addr.arpa") {
|
||||
// RFC 6303: private + loopback + link-local reverse DNS
|
||||
@@ -1187,6 +1222,201 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn pipeline_filter_aaaa_returns_nodata() {
|
||||
let mut ctx = crate::testutil::test_ctx().await;
|
||||
ctx.filter_aaaa = true;
|
||||
let ctx = Arc::new(ctx);
|
||||
|
||||
let (resp, path) = resolve_in_test(&ctx, "example.com", QueryType::AAAA).await;
|
||||
assert_eq!(path, QueryPath::Local);
|
||||
assert_eq!(resp.header.rescode, ResultCode::NOERROR);
|
||||
assert!(resp.answers.is_empty(), "AAAA must be filtered to NODATA");
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn pipeline_filter_aaaa_leaves_a_queries_alone() {
|
||||
let mut upstream_resp = DnsPacket::new();
|
||||
upstream_resp.header.response = true;
|
||||
upstream_resp.header.rescode = ResultCode::NOERROR;
|
||||
upstream_resp.answers.push(DnsRecord::A {
|
||||
domain: "example.com".to_string(),
|
||||
addr: Ipv4Addr::new(93, 184, 216, 34),
|
||||
ttl: 300,
|
||||
});
|
||||
let upstream_addr = crate::testutil::mock_upstream(upstream_resp).await;
|
||||
|
||||
let mut ctx = crate::testutil::test_ctx().await;
|
||||
ctx.filter_aaaa = true;
|
||||
ctx.upstream_pool
|
||||
.lock()
|
||||
.unwrap()
|
||||
.set_primary(vec![Upstream::Udp(upstream_addr)]);
|
||||
let ctx = Arc::new(ctx);
|
||||
|
||||
let (resp, path) = resolve_in_test(&ctx, "example.com", QueryType::A).await;
|
||||
assert_eq!(path, QueryPath::Upstream);
|
||||
assert_eq!(resp.answers.len(), 1);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn pipeline_filter_aaaa_respects_override() {
|
||||
let mut ctx = crate::testutil::test_ctx().await;
|
||||
ctx.filter_aaaa = true;
|
||||
ctx.overrides
|
||||
.write()
|
||||
.unwrap()
|
||||
.insert("v6.test", "2001:db8::1", 60, None)
|
||||
.unwrap();
|
||||
let ctx = Arc::new(ctx);
|
||||
|
||||
let (resp, path) = resolve_in_test(&ctx, "v6.test", QueryType::AAAA).await;
|
||||
assert_eq!(path, QueryPath::Overridden);
|
||||
assert_eq!(resp.answers.len(), 1, "override must win over filter");
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn pipeline_filter_aaaa_strips_ipv6hint_from_https_and_svcb() {
|
||||
let rdata = crate::svcb::build_rdata(
|
||||
1,
|
||||
&[],
|
||||
&[
|
||||
(1, vec![0x02, b'h', b'3']),
|
||||
(
|
||||
6,
|
||||
vec![
|
||||
0x26, 0x06, 0x47, 0x00, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x01,
|
||||
],
|
||||
),
|
||||
],
|
||||
);
|
||||
|
||||
let mut pkt = DnsPacket::new();
|
||||
pkt.header.response = true;
|
||||
pkt.header.rescode = ResultCode::NOERROR;
|
||||
pkt.questions.push(crate::question::DnsQuestion {
|
||||
name: "hints.test".to_string(),
|
||||
qtype: QueryType::HTTPS,
|
||||
});
|
||||
pkt.answers.push(DnsRecord::UNKNOWN {
|
||||
domain: "hints.test".to_string(),
|
||||
qtype: 65,
|
||||
data: rdata.clone(),
|
||||
ttl: 300,
|
||||
});
|
||||
|
||||
let mut svcb_pkt = pkt.clone();
|
||||
svcb_pkt.questions[0].name = "svc.test".to_string();
|
||||
svcb_pkt.questions[0].qtype = QueryType::UNKNOWN(64);
|
||||
if let DnsRecord::UNKNOWN { domain, qtype, .. } = &mut svcb_pkt.answers[0] {
|
||||
*domain = "svc.test".to_string();
|
||||
*qtype = 64;
|
||||
}
|
||||
|
||||
let mut ctx = crate::testutil::test_ctx().await;
|
||||
ctx.filter_aaaa = true;
|
||||
ctx.cache
|
||||
.write()
|
||||
.unwrap()
|
||||
.insert("hints.test", QueryType::HTTPS, &pkt);
|
||||
ctx.cache
|
||||
.write()
|
||||
.unwrap()
|
||||
.insert("svc.test", QueryType::UNKNOWN(64), &svcb_pkt);
|
||||
let ctx = Arc::new(ctx);
|
||||
|
||||
for (name, qtype, label) in [
|
||||
("hints.test", QueryType::HTTPS, "HTTPS"),
|
||||
("svc.test", QueryType::UNKNOWN(64), "SVCB"),
|
||||
] {
|
||||
let (resp, path) = resolve_in_test(&ctx, name, qtype).await;
|
||||
assert_eq!(path, QueryPath::Cached, "{label}");
|
||||
assert_eq!(resp.answers.len(), 1, "{label}");
|
||||
match &resp.answers[0] {
|
||||
DnsRecord::UNKNOWN { data, .. } => {
|
||||
assert!(
|
||||
data.len() < rdata.len(),
|
||||
"{label}: ipv6hint (20 bytes) must be removed"
|
||||
);
|
||||
// Bytes for key=6 must not appear at any 4-byte boundary in the
|
||||
// params section — cheap structural check.
|
||||
assert!(
|
||||
!data.windows(4).any(|w| w == [0, 6, 0, 16]),
|
||||
"{label}: ipv6hint TLV header must be absent"
|
||||
);
|
||||
}
|
||||
other => panic!("{label}: expected UNKNOWN record, got {other:?}"),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn pipeline_filter_aaaa_preserves_ipv6hint_for_dnssec_clients() {
|
||||
// Regression guard for the DO-bit gate in resolve_query: modifying
|
||||
// HTTPS rdata invalidates any accompanying RRSIG, so a DO=1 client
|
||||
// must receive the record untouched even when filter_aaaa is on.
|
||||
let rdata = crate::svcb::build_rdata(
|
||||
1,
|
||||
&[],
|
||||
&[(
|
||||
6,
|
||||
vec![
|
||||
0x26, 0x06, 0x47, 0x00, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x01,
|
||||
],
|
||||
)],
|
||||
);
|
||||
|
||||
let mut pkt = DnsPacket::new();
|
||||
pkt.header.response = true;
|
||||
pkt.header.rescode = ResultCode::NOERROR;
|
||||
pkt.questions.push(crate::question::DnsQuestion {
|
||||
name: "hints.test".to_string(),
|
||||
qtype: QueryType::HTTPS,
|
||||
});
|
||||
pkt.answers.push(DnsRecord::UNKNOWN {
|
||||
domain: "hints.test".to_string(),
|
||||
qtype: 65,
|
||||
data: rdata.clone(),
|
||||
ttl: 300,
|
||||
});
|
||||
|
||||
let mut ctx = crate::testutil::test_ctx().await;
|
||||
ctx.filter_aaaa = true;
|
||||
ctx.cache
|
||||
.write()
|
||||
.unwrap()
|
||||
.insert("hints.test", QueryType::HTTPS, &pkt);
|
||||
let ctx = Arc::new(ctx);
|
||||
|
||||
// Build a query with EDNS DO bit set — can't use resolve_in_test
|
||||
// because it constructs a plain query without EDNS.
|
||||
let mut query = DnsPacket::query(0xBEEF, "hints.test", QueryType::HTTPS);
|
||||
query.edns = Some(crate::packet::EdnsOpt {
|
||||
do_bit: true,
|
||||
..Default::default()
|
||||
});
|
||||
let mut buf = BytePacketBuffer::new();
|
||||
query.write(&mut buf).unwrap();
|
||||
let raw = &buf.buf[..buf.pos];
|
||||
let src: SocketAddr = "127.0.0.1:1234".parse().unwrap();
|
||||
|
||||
let (resp_buf, _) = resolve_query(query, raw, src, &ctx, Transport::Udp)
|
||||
.await
|
||||
.unwrap();
|
||||
let mut resp_parse_buf = BytePacketBuffer::from_bytes(resp_buf.filled());
|
||||
let resp = DnsPacket::from_buffer(&mut resp_parse_buf).unwrap();
|
||||
|
||||
match &resp.answers[0] {
|
||||
DnsRecord::UNKNOWN { data, .. } => {
|
||||
assert_eq!(
|
||||
data, &rdata,
|
||||
"ipv6hint must be preserved for DO-bit clients"
|
||||
);
|
||||
}
|
||||
other => panic!("expected UNKNOWN record, got {:?}", other),
|
||||
}
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn pipeline_blocklist_sinkhole() {
|
||||
let ctx = crate::testutil::test_ctx().await;
|
||||
|
||||
@@ -25,6 +25,7 @@ pub mod service_store;
|
||||
pub mod setup_phone;
|
||||
pub mod srtt;
|
||||
pub mod stats;
|
||||
pub mod svcb;
|
||||
pub mod system_dns;
|
||||
pub mod tls;
|
||||
pub mod wire;
|
||||
|
||||
@@ -85,6 +85,14 @@ impl DnsPacket {
|
||||
+ self.edns.as_ref().map_or(0, |e| e.options.capacity())
|
||||
}
|
||||
|
||||
/// Apply `f` to every record in the three RR sections (answers,
|
||||
/// authorities, resources). Does not touch questions or edns.
|
||||
pub fn for_each_record_mut(&mut self, mut f: impl FnMut(&mut DnsRecord)) {
|
||||
self.answers.iter_mut().for_each(&mut f);
|
||||
self.authorities.iter_mut().for_each(&mut f);
|
||||
self.resources.iter_mut().for_each(&mut f);
|
||||
}
|
||||
|
||||
pub fn response_from(query: &DnsPacket, rescode: crate::header::ResultCode) -> DnsPacket {
|
||||
let mut resp = DnsPacket::new();
|
||||
resp.header.id = query.header.id;
|
||||
|
||||
@@ -236,6 +236,7 @@ pub async fn run(config_path: String) -> crate::Result<()> {
|
||||
ca_pem,
|
||||
mobile_enabled: config.mobile.enabled,
|
||||
mobile_port: config.mobile.port,
|
||||
filter_aaaa: config.server.filter_aaaa,
|
||||
});
|
||||
|
||||
let zone_count: usize = ctx.zone_map.values().map(|m| m.len()).sum();
|
||||
|
||||
179
src/svcb.rs
Normal file
179
src/svcb.rs
Normal file
@@ -0,0 +1,179 @@
|
||||
//! Minimal SVCB/HTTPS (RFC 9460) RDATA parser — just enough to strip
|
||||
//! the `ipv6hint` SvcParam. Used by the `filter_aaaa` feature so
|
||||
//! HTTPS-record-aware clients (Chrome ≥103, Firefox, Safari) don't
|
||||
//! receive v6 address hints on IPv4-only networks.
|
||||
|
||||
/// SvcParamKey = 6 (RFC 9460 §14.3.2).
|
||||
const IPV6_HINT_KEY: u16 = 6;
|
||||
|
||||
/// Strip the `ipv6hint` SvcParam from an HTTPS/SVCB RDATA blob.
|
||||
///
|
||||
/// Returns `Some(new_rdata)` if `ipv6hint` was present and removed.
|
||||
/// Returns `None` if the record had no `ipv6hint`, or if the RDATA
|
||||
/// couldn't be parsed — in both cases the caller should keep the
|
||||
/// original bytes untouched.
|
||||
///
|
||||
/// SVCB RDATA (RFC 9460 §2.2):
|
||||
/// SvcPriority (u16)
|
||||
/// TargetName (uncompressed DNS name — labels terminated by 0 octet)
|
||||
/// SvcParams (series of {u16 key, u16 len, opaque[len] value}, sorted by key)
|
||||
pub fn strip_ipv6hint(rdata: &[u8]) -> Option<Vec<u8>> {
|
||||
if rdata.len() < 2 {
|
||||
return None;
|
||||
}
|
||||
let mut pos = 2;
|
||||
|
||||
// TargetName — uncompressed per RFC 9460 §2.2
|
||||
loop {
|
||||
let len = *rdata.get(pos)? as usize;
|
||||
pos += 1;
|
||||
if len == 0 {
|
||||
break;
|
||||
}
|
||||
if len & 0xC0 != 0 {
|
||||
// Pointer: forbidden in SVCB but defend against a broken upstream.
|
||||
return None;
|
||||
}
|
||||
pos = pos.checked_add(len)?;
|
||||
if pos > rdata.len() {
|
||||
return None;
|
||||
}
|
||||
}
|
||||
|
||||
// Scan params once to decide whether we need to rebuild.
|
||||
let params_start = pos;
|
||||
let mut scan = pos;
|
||||
let mut has_ipv6hint = false;
|
||||
while scan < rdata.len() {
|
||||
if scan + 4 > rdata.len() {
|
||||
return None;
|
||||
}
|
||||
let key = u16::from_be_bytes([rdata[scan], rdata[scan + 1]]);
|
||||
let vlen = u16::from_be_bytes([rdata[scan + 2], rdata[scan + 3]]) as usize;
|
||||
let end = scan.checked_add(4)?.checked_add(vlen)?;
|
||||
if end > rdata.len() {
|
||||
return None;
|
||||
}
|
||||
if key == IPV6_HINT_KEY {
|
||||
has_ipv6hint = true;
|
||||
}
|
||||
scan = end;
|
||||
}
|
||||
if scan != rdata.len() || !has_ipv6hint {
|
||||
return None;
|
||||
}
|
||||
|
||||
// Rebuild without ipv6hint, preserving param order (RFC 9460 requires
|
||||
// ascending key order, which we preserve by filtering in place).
|
||||
let mut out = Vec::with_capacity(rdata.len());
|
||||
out.extend_from_slice(&rdata[..params_start]);
|
||||
let mut pos = params_start;
|
||||
while pos < rdata.len() {
|
||||
let key = u16::from_be_bytes([rdata[pos], rdata[pos + 1]]);
|
||||
let vlen = u16::from_be_bytes([rdata[pos + 2], rdata[pos + 3]]) as usize;
|
||||
let end = pos + 4 + vlen;
|
||||
if key != IPV6_HINT_KEY {
|
||||
out.extend_from_slice(&rdata[pos..end]);
|
||||
}
|
||||
pos = end;
|
||||
}
|
||||
Some(out)
|
||||
}
|
||||
|
||||
/// Build an SVCB RDATA blob from a priority, target labels, and
|
||||
/// (key, value) param pairs. Shared by `svcb` unit tests and `ctx`
|
||||
/// pipeline tests that need to seed the cache with a synthetic HTTPS RR.
|
||||
#[cfg(test)]
|
||||
pub(crate) fn build_rdata(priority: u16, target: &[&str], params: &[(u16, Vec<u8>)]) -> Vec<u8> {
|
||||
let mut out = Vec::new();
|
||||
out.extend_from_slice(&priority.to_be_bytes());
|
||||
for label in target {
|
||||
out.push(label.len() as u8);
|
||||
out.extend_from_slice(label.as_bytes());
|
||||
}
|
||||
out.push(0);
|
||||
for (key, value) in params {
|
||||
out.extend_from_slice(&key.to_be_bytes());
|
||||
out.extend_from_slice(&(value.len() as u16).to_be_bytes());
|
||||
out.extend_from_slice(value);
|
||||
}
|
||||
out
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
|
||||
fn alpn_h3() -> (u16, Vec<u8>) {
|
||||
// alpn = ["h3"]: one length-prefixed ALPN id
|
||||
(1, vec![0x02, b'h', b'3'])
|
||||
}
|
||||
|
||||
fn ipv4hint_single() -> (u16, Vec<u8>) {
|
||||
(4, vec![93, 184, 216, 34])
|
||||
}
|
||||
|
||||
fn ipv6hint_single() -> (u16, Vec<u8>) {
|
||||
// 2606:4700::1
|
||||
(
|
||||
6,
|
||||
vec![
|
||||
0x26, 0x06, 0x47, 0x00, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x01,
|
||||
],
|
||||
)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn strips_ipv6hint_and_keeps_other_params() {
|
||||
let rdata = build_rdata(1, &[], &[alpn_h3(), ipv4hint_single(), ipv6hint_single()]);
|
||||
let stripped = strip_ipv6hint(&rdata).expect("ipv6hint present → stripped");
|
||||
let expected = build_rdata(1, &[], &[alpn_h3(), ipv4hint_single()]);
|
||||
assert_eq!(stripped, expected);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn no_ipv6hint_returns_none() {
|
||||
let rdata = build_rdata(1, &[], &[alpn_h3(), ipv4hint_single()]);
|
||||
assert!(strip_ipv6hint(&rdata).is_none());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn alias_mode_empty_params_returns_none() {
|
||||
let rdata = build_rdata(0, &["example", "com"], &[]);
|
||||
assert!(strip_ipv6hint(&rdata).is_none());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn only_ipv6hint_yields_empty_param_section() {
|
||||
let rdata = build_rdata(1, &[], &[ipv6hint_single()]);
|
||||
let stripped = strip_ipv6hint(&rdata).expect("ipv6hint present → stripped");
|
||||
let expected = build_rdata(1, &[], &[]);
|
||||
assert_eq!(stripped, expected);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn preserves_target_name() {
|
||||
let rdata = build_rdata(1, &["svc", "example", "net"], &[ipv6hint_single()]);
|
||||
let stripped = strip_ipv6hint(&rdata).unwrap();
|
||||
assert!(stripped.starts_with(&[0x00, 0x01])); // priority
|
||||
assert_eq!(&stripped[2..6], b"\x03svc");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn truncated_rdata_returns_none() {
|
||||
// Priority only, no target terminator.
|
||||
assert!(strip_ipv6hint(&[0, 1, 3, b'c', b'o', b'm']).is_none());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn empty_input_returns_none() {
|
||||
assert!(strip_ipv6hint(&[]).is_none());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn param_length_overflow_returns_none() {
|
||||
// key=6, length=0xFFFF but value is short — malformed.
|
||||
let rdata = vec![0, 1, 0, 0, 6, 0xFF, 0xFF, 0, 1, 2];
|
||||
assert!(strip_ipv6hint(&rdata).is_none());
|
||||
}
|
||||
}
|
||||
@@ -63,6 +63,7 @@ pub async fn test_ctx() -> ServerCtx {
|
||||
ca_pem: None,
|
||||
mobile_enabled: false,
|
||||
mobile_port: 8765,
|
||||
filter_aaaa: false,
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1,7 +1,10 @@
|
||||
#!/usr/bin/env bash
|
||||
# Integration test suite for Numa
|
||||
# Runs a test instance on port 5354, validates all features, exits with status.
|
||||
# Usage: ./tests/integration.sh [release|debug]
|
||||
# Usage:
|
||||
# ./tests/integration.sh [release|debug] # all suites
|
||||
# SUITES=7 ./tests/integration.sh # only Suite 7
|
||||
# SUITES=1,3,7 ./tests/integration.sh # Suites 1, 3, and 7
|
||||
|
||||
set -euo pipefail
|
||||
|
||||
@@ -14,6 +17,14 @@ LOG="/tmp/numa-integration-test.log"
|
||||
PASSED=0
|
||||
FAILED=0
|
||||
|
||||
# Suite filter: empty runs all; comma list runs a subset.
|
||||
SUITES="${SUITES:-}"
|
||||
should_run_suite() {
|
||||
[ -z "$SUITES" ] && return 0
|
||||
case ",$SUITES," in *",$1,"*) return 0;; esac
|
||||
return 1
|
||||
}
|
||||
|
||||
# Colors
|
||||
GREEN="\033[32m"
|
||||
RED="\033[31m"
|
||||
@@ -166,6 +177,7 @@ CONF
|
||||
}
|
||||
|
||||
# ---- Suite 1: Recursive mode + DNSSEC ----
|
||||
if should_run_suite 1; then
|
||||
echo ""
|
||||
echo "╔══════════════════════════════════════════╗"
|
||||
echo "║ Suite 1: Recursive + DNSSEC + Blocking ║"
|
||||
@@ -234,7 +246,10 @@ kill "$NUMA_PID" 2>/dev/null || true
|
||||
wait "$NUMA_PID" 2>/dev/null || true
|
||||
sleep 1
|
||||
|
||||
fi # end Suite 1
|
||||
|
||||
# ---- Suite 2: Forward mode (backward compat) ----
|
||||
if should_run_suite 2; then
|
||||
echo ""
|
||||
echo "╔══════════════════════════════════════════╗"
|
||||
echo "║ Suite 2: Forward (DoH) + Blocking ║"
|
||||
@@ -261,7 +276,10 @@ enabled = true
|
||||
enabled = false
|
||||
"
|
||||
|
||||
fi # end Suite 2
|
||||
|
||||
# ---- Suite 3: Forward UDP (plain, no DoH) ----
|
||||
if should_run_suite 3; then
|
||||
echo ""
|
||||
echo "╔══════════════════════════════════════════╗"
|
||||
echo "║ Suite 3: Forward (UDP) + No Blocking ║"
|
||||
@@ -307,7 +325,10 @@ kill "$NUMA_PID" 2>/dev/null || true
|
||||
wait "$NUMA_PID" 2>/dev/null || true
|
||||
sleep 1
|
||||
|
||||
fi # end Suite 3
|
||||
|
||||
# ---- Suite 4: Local zones + Overrides API ----
|
||||
if should_run_suite 4; then
|
||||
echo ""
|
||||
echo "╔══════════════════════════════════════════╗"
|
||||
echo "║ Suite 4: Local Zones + Overrides API ║"
|
||||
@@ -416,7 +437,10 @@ kill "$NUMA_PID" 2>/dev/null || true
|
||||
wait "$NUMA_PID" 2>/dev/null || true
|
||||
sleep 1
|
||||
|
||||
fi # end Suite 4
|
||||
|
||||
# ---- Suite 5: DNS-over-TLS (RFC 7858) ----
|
||||
if should_run_suite 5; then
|
||||
echo ""
|
||||
echo "╔══════════════════════════════════════════╗"
|
||||
echo "║ Suite 5: DNS-over-TLS (RFC 7858) ║"
|
||||
@@ -538,7 +562,10 @@ CONF
|
||||
fi
|
||||
sleep 1
|
||||
|
||||
fi # end Suite 5
|
||||
|
||||
# ---- Suite 6: Proxy + DoT coexistence ----
|
||||
if should_run_suite 6; then
|
||||
echo ""
|
||||
echo "╔══════════════════════════════════════════╗"
|
||||
echo "║ Suite 6: Proxy + DoT Coexistence ║"
|
||||
@@ -698,6 +725,135 @@ CONF
|
||||
rm -rf "$NUMA_DATA"
|
||||
fi
|
||||
|
||||
fi # end Suite 6
|
||||
|
||||
# ---- Suite 7: filter_aaaa (IPv4-only networks) ----
|
||||
if should_run_suite 7; then
|
||||
echo ""
|
||||
echo "╔══════════════════════════════════════════╗"
|
||||
echo "║ Suite 7: filter_aaaa ║"
|
||||
echo "╚══════════════════════════════════════════╝"
|
||||
|
||||
# Config A — filter on, with a local AAAA zone to prove local data bypass.
|
||||
cat > "$CONFIG" << 'CONF'
|
||||
[server]
|
||||
bind_addr = "127.0.0.1:5354"
|
||||
api_port = 5381
|
||||
filter_aaaa = true
|
||||
|
||||
[upstream]
|
||||
mode = "forward"
|
||||
address = "9.9.9.9"
|
||||
port = 53
|
||||
|
||||
[cache]
|
||||
max_entries = 10000
|
||||
|
||||
[blocking]
|
||||
enabled = false
|
||||
|
||||
[proxy]
|
||||
enabled = false
|
||||
|
||||
[[zones]]
|
||||
domain = "v6.test"
|
||||
record_type = "AAAA"
|
||||
value = "2001:db8::1"
|
||||
ttl = 60
|
||||
CONF
|
||||
|
||||
RUST_LOG=info "$BINARY" "$CONFIG" > "$LOG" 2>&1 &
|
||||
NUMA_PID=$!
|
||||
sleep 3
|
||||
|
||||
DIG="dig @127.0.0.1 -p $PORT +time=5 +tries=1"
|
||||
|
||||
echo ""
|
||||
echo "=== filter_aaaa = true ==="
|
||||
|
||||
# A queries must be untouched.
|
||||
check "A record resolves under filter_aaaa" \
|
||||
"." \
|
||||
"$($DIG google.com A +short | head -1)"
|
||||
|
||||
# AAAA must be NOERROR (NODATA), not NXDOMAIN, not SERVFAIL.
|
||||
check "AAAA returns NOERROR (not NXDOMAIN)" \
|
||||
"status: NOERROR" \
|
||||
"$($DIG google.com AAAA 2>&1 | grep 'status:')"
|
||||
|
||||
check "AAAA returns zero answers (NODATA shape)" \
|
||||
"ANSWER: 0" \
|
||||
"$($DIG google.com AAAA 2>&1 | grep -oE 'ANSWER: [0-9]+' | head -1)"
|
||||
|
||||
# Local zone AAAA must survive the filter (PR claim: local data bypasses).
|
||||
check "Local [[zones]] AAAA bypasses filter" \
|
||||
"2001:db8::1" \
|
||||
"$($DIG v6.test AAAA +short)"
|
||||
|
||||
# HTTPS RR: ipv6hint (SvcParamKey 6) must be stripped. Query as `type65`
|
||||
# because dig 9.10.6 (macOS) misparses `HTTPS` as a domain name; `type65`
|
||||
# works on both 9.10.6 and 9.18. Assert on the raw rdata hex (RFC 3597
|
||||
# generic format), since dig 9.10.6 doesn't pretty-print HTTPS params.
|
||||
# cloudflare.com's ipv6hint values sit under the 2606:4700 prefix —
|
||||
# checking that `26064700` is absent from the rdata hex is a precise,
|
||||
# upstream-stable signal that the TLV was stripped.
|
||||
HTTPS_OUT=$($DIG cloudflare.com type65 2>&1)
|
||||
if echo "$HTTPS_OUT" | grep -qE "cloudflare\.com\..*IN[[:space:]]+TYPE65"; then
|
||||
HTTPS_HEX=$(echo "$HTTPS_OUT" | grep -A5 "IN[[:space:]]*TYPE65" | tr -d " \t\n")
|
||||
if echo "$HTTPS_HEX" | grep -qi "26064700"; then
|
||||
check "HTTPS ipv6hint stripped (2606:4700 absent from rdata)" "absent" "present"
|
||||
else
|
||||
check "HTTPS ipv6hint stripped (2606:4700 absent from rdata)" "absent" "absent"
|
||||
fi
|
||||
else
|
||||
# Upstream didn't return an HTTPS record — skip rather than false-pass.
|
||||
printf " ${DIM}~ HTTPS ipv6hint stripped (skipped: no HTTPS RR returned by upstream)${RESET}\n"
|
||||
fi
|
||||
|
||||
kill "$NUMA_PID" 2>/dev/null || true
|
||||
wait "$NUMA_PID" 2>/dev/null || true
|
||||
sleep 1
|
||||
|
||||
# Config B — filter off. Regression guard: prove AAAA answers come back
|
||||
# when the flag isn't set, so a network failure in Config A can't silently
|
||||
# pass as "filter working".
|
||||
cat > "$CONFIG" << 'CONF'
|
||||
[server]
|
||||
bind_addr = "127.0.0.1:5354"
|
||||
api_port = 5381
|
||||
|
||||
[upstream]
|
||||
mode = "forward"
|
||||
address = "9.9.9.9"
|
||||
port = 53
|
||||
|
||||
[cache]
|
||||
max_entries = 10000
|
||||
|
||||
[blocking]
|
||||
enabled = false
|
||||
|
||||
[proxy]
|
||||
enabled = false
|
||||
CONF
|
||||
|
||||
RUST_LOG=info "$BINARY" "$CONFIG" > "$LOG" 2>&1 &
|
||||
NUMA_PID=$!
|
||||
sleep 3
|
||||
|
||||
echo ""
|
||||
echo "=== filter_aaaa unset (regression guard) ==="
|
||||
|
||||
check "AAAA returns real answers with filter off" \
|
||||
":" \
|
||||
"$($DIG google.com AAAA +short | head -1)"
|
||||
|
||||
kill "$NUMA_PID" 2>/dev/null || true
|
||||
wait "$NUMA_PID" 2>/dev/null || true
|
||||
sleep 1
|
||||
|
||||
fi # end Suite 7
|
||||
|
||||
# Summary
|
||||
echo ""
|
||||
TOTAL=$((PASSED + FAILED))
|
||||
|
||||
Reference in New Issue
Block a user