dearsky/pico-fido
1
0
Fork 0
Code Issues 46 Pull Requests 1 Actions Packages Projects Releases 22 Wiki Activity

Fix cbor processing when unknown command is used.

Browse Source 
Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
This commit is contained in:
Pol Henarejos
2023-03-03 00:23:12 +01:00
parent 267e66eaee
commit 03f29f5be6
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/fido/cbor.c
View File

@@ -45,8 +45,9 @@ size_t cbor_len = 0;
uint8_t cmd = 0; uint8_t cmd = 0;
int cbor_parse(uint8_t cmd, const uint8_t *data, size_t len) { int cbor_parse(uint8_t cmd, const uint8_t *data, size_t len) {
if (len == 0) if (len == 0 && cmd == CTAPHID_CBOR)
return CTAP1_ERR_INVALID_LEN; return CTAP1_ERR_INVALID_LEN;
if (len > 0)
DEBUG_DATA(data+1,len-1); DEBUG_DATA(data+1,len-1);
driver_prepare_response_hid(); driver_prepare_response_hid();
if (cmd == CTAPHID_CBOR) { if (cmd == CTAPHID_CBOR) {
@@ -74,7 +75,7 @@ int cbor_parse(uint8_t cmd, const uint8_t *data, size_t len) {
else if (cmd == CTAP_VENDOR_CBOR) { else if (cmd == CTAP_VENDOR_CBOR) {
return cbor_vendor(data, len); return cbor_vendor(data, len);
} }
return CTAP2_ERR_INVALID_CBOR; return CTAP1_ERR_INVALID_CMD;
} }
#ifndef ENABLE_EMULATION #ifndef ENABLE_EMULATION