From 3b25eb295cd6427c65662f1b2894d0ac68f7ee43 Mon Sep 17 00:00:00 2001
From: Pol Henarejos <pol.henarejos@cttc.es>
Date: Thu, 22 Sep 2022 09:30:13 +0200
Subject: [PATCH] Fix get assertion.

Credentials must be sorted in descending order.

Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
---
 src/fido/cbor_get_assertion.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/fido/cbor_get_assertion.c b/src/fido/cbor_get_assertion.c
index ec5a1ff..653e9a4 100644
--- a/src/fido/cbor_get_assertion.c
+++ b/src/fido/cbor_get_assertion.c
@@ -40,7 +40,6 @@ size_t lenx = 0;
 
 int cbor_get_next_assertion(const uint8_t *data, size_t len) {
     CborError error = CborNoError;
-    printf("%d %d %ld %ld\n", credentialCounter, numberOfCredentialsx, timerx, board_millis());
     if (credentialCounter >= numberOfCredentialsx)
         CBOR_ERROR(CTAP2_ERR_NOT_ALLOWED);
     if (timerx+30*1000 < board_millis())
@@ -286,10 +285,19 @@ int cbor_get_assertion(const uint8_t *data, size_t len, bool next) {
                     creds[numberOfCredentials++] = creds[i];
             }
         }
-        printf("!! %d %d %d\n", numberOfCredentials, creds_len, allowList_len);
         if (numberOfCredentials == 0)
             CBOR_ERROR(CTAP2_ERR_NO_CREDENTIALS);
 
+        for (int i = 0; i < numberOfCredentials; i++) {
+            for (int j = i + 1; j < numberOfCredentials; j++) {
+                if (creds[j].creation > creds[i].creation) {
+                    Credential tmp = creds[j];
+                    creds[j] = creds[i];
+                    creds[i] = tmp;
+                }
+            }
+        }
+
         if (options.up == ptrue || options.present == false || options.up == NULL) { //9.1
             if (pinUvAuthParam.present == true) {
                 if (getUserPresentFlagValue() == false) {
@@ -302,8 +310,6 @@ int cbor_get_assertion(const uint8_t *data, size_t len, bool next) {
             clearUserVerifiedFlag();
             clearPinUvAuthTokenPermissionsExceptLbw();
         }
-        if (numberOfCredentials == 0)
-            CBOR_ERROR(CTAP2_ERR_NO_CREDENTIALS);
 
         if (!(flags & FIDO2_AUT_FLAG_UP) && !(flags & FIDO2_AUT_FLAG_UV)) {
             selcred = &creds[0];