dearsky/pico-fido
1
0
Fork 0
Code Issues 46 Pull Requests 1 Actions Packages Projects Releases 22 Wiki Activity

Fix potential crash invoking OTP.

Browse Source 
Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
This commit is contained in:
Pol Henarejos
2024-08-20 14:28:09 +02:00
parent a0d9ad7a3a
commit 8d49ed5ffc
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/fido/otp.c
View File

@@ -566,6 +566,8 @@ int otp_hid_set_report_cb(uint8_t itf,
uint16_t residual_crc = calculate_crc(otp_frame_rx, 64), rcrc = (otp_frame_rx[66] << 8 | otp_frame_rx[65]); uint16_t residual_crc = calculate_crc(otp_frame_rx, 64), rcrc = (otp_frame_rx[66] << 8 | otp_frame_rx[65]);
uint8_t slot_id = otp_frame_rx[64]; uint8_t slot_id = otp_frame_rx[64];
if (residual_crc == rcrc) { if (residual_crc == rcrc) {
uint8_t hdr[5];
apdu.header = hdr;
apdu.data = otp_frame_rx; apdu.data = otp_frame_rx;
apdu.nc = 64; apdu.nc = 64;
apdu.rdata = otp_frame_tx; apdu.rdata = otp_frame_tx;
@@ -617,8 +619,8 @@ uint16_t otp_hid_get_report_cb(uint8_t itf,
otp_curr_seq = otp_exp_seq = 0; otp_curr_seq = otp_exp_seq = 0;
} }
else { else {
res_APDU = buffer;
otp_status(); otp_status();
memcpy(buffer, res_APDU, 7);
} }
return reqlen; return reqlen;