dearsky/pico-fido
1
0
Fork 0
Code Issues 46 Pull Requests 1 Actions Packages Projects Releases 22 Wiki Activity

Fix return errors.

Browse Source 
Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
This commit is contained in:
Pol Henarejos
2022-09-23 18:29:23 +02:00
parent 7a6b8a6af4
commit 9cbb53716b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/fido/cmd_authenticate.c
View File

@@ -32,7 +32,7 @@ int cmd_authenticate() {
if (apdu.nc < CTAP_CHAL_SIZE+CTAP_APPID_SIZE+1+1) if (apdu.nc < CTAP_CHAL_SIZE+CTAP_APPID_SIZE+1+1)
return SW_WRONG_DATA(); return SW_WRONG_DATA();
if (req->keyHandleLen < KEY_HANDLE_LEN) if (req->keyHandleLen < KEY_HANDLE_LEN)
return SW_WRONG_DATA(); return SW_INCORRECT_PARAMS();
if (P1(apdu) == CTAP_AUTH_ENFORCE && wait_button_pressed() == true) if (P1(apdu) == CTAP_AUTH_ENFORCE && wait_button_pressed() == true)
return SW_CONDITIONS_NOT_SATISFIED(); return SW_CONDITIONS_NOT_SATISFIED();
@@ -53,9 +53,10 @@ int cmd_authenticate() {
mbedtls_ecdsa_free(&key); mbedtls_ecdsa_free(&key);
return SW_EXEC_ERROR(); return SW_EXEC_ERROR();
} }
if (verify_key(req->appId, req->keyHandle, &key) != 0) {
return SW_INCORRECT_PARAMS();
}
if (P1(apdu) == CTAP_AUTH_CHECK_ONLY) { if (P1(apdu) == CTAP_AUTH_CHECK_ONLY) {
if (verify_key(req->appId, req->keyHandle, &key) != 0)
return SW_WRONG_DATA();
return SW_CONDITIONS_NOT_SATISFIED(); return SW_CONDITIONS_NOT_SATISFIED();
} }
resp->flags = 0; resp->flags = 0;