dearsky/pico-fido
1
0
Fork 0
Code Issues 46 Pull Requests 1 Actions Packages Projects Releases 22 Wiki Activity

Fix cleared permissions on make credential when UP is not present.

Browse Source 
Following 14.1, flags shall be cleared only when UP == true.

Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
This commit is contained in:
Pol Henarejos
2024-06-07 20:57:21 +02:00
parent 1f0e1fb8f4
commit b0b0187919
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/fido/cbor_make_credential.c
View File

@@ -313,10 +313,12 @@ int cbor_make_credential(const uint8_t *data, size_t len) {
} }
} }
flags |= FIDO2_AUT_FLAG_UP; flags |= FIDO2_AUT_FLAG_UP;
if (options.up == ptrue) {
clearUserPresentFlag(); clearUserPresentFlag();
clearUserVerifiedFlag(); clearUserVerifiedFlag();
clearPinUvAuthTokenPermissionsExceptLbw(); clearPinUvAuthTokenPermissionsExceptLbw();
} }
}
const known_app_t *ka = find_app_by_rp_id_hash(rp_id_hash); const known_app_t *ka = find_app_by_rp_id_hash(rp_id_hash);