From 804ee68e86755c7b6e67fd612161c1f41a28d54a Mon Sep 17 00:00:00 2001 From: Pol Henarejos Date: Thu, 8 Jan 2026 10:46:51 +0100 Subject: [PATCH] Remove non-standard MAKE CREDENTIAL step. It may collide with other userName and the purpose is achieved cleaner via Rescue interface. Signed-off-by: Pol Henarejos --- src/fido/cbor_make_credential.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/src/fido/cbor_make_credential.c b/src/fido/cbor_make_credential.c index 25a5d41..b53cd58 100644 --- a/src/fido/cbor_make_credential.c +++ b/src/fido/cbor_make_credential.c @@ -613,24 +613,6 @@ int cbor_make_credential(const uint8_t *data, size_t len) { CBOR_ERROR(CTAP2_ERR_PROCESSING); } - if (user.id.len > 0 && user.parent.name.len > 0 && user.displayName.len > 0) { - if (memcmp(user.parent.name.data, "+pico", 5) == 0) { - options.rk = pfalse; -#ifndef ENABLE_EMULATION - uint8_t *p = (uint8_t *)user.parent.name.data + 5; - if (memcmp(p, "CommissionProfile", 17) == 0) { - ret = phy_unserialize_data(user.id.data, (uint16_t)user.id.len, &phy_data); - if (ret == PICOKEY_OK) { - ret = phy_save(); - } - } -#endif - if (ret != PICOKEY_OK) { - CBOR_ERROR(CTAP2_ERR_PROCESSING); - } - } - } - uint8_t largeBlobKey[32] = {0}; if (extensions.largeBlobKey == ptrue && options.rk == ptrue) { ret = credential_derive_large_blob_key(cred_id, cred_id_len, largeBlobKey);