dearsky/pico-hsm
1
0
Fork 0
Code Issues 17 Pull Requests 4 Actions Packages Projects Releases 26 Wiki Activity

Missing liveness button check for bip32 signing operations #103

New Issue
Open
opened 2025-08-08 21:36:53 +08:00 by eliasnaur · 0 comments
eliasnaur commented 2025-08-08 21:36:53 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

I believe the BIP32 signing operation should be guarded by the hardware button, if enabled. While working on https://github.com/polhenarejos/pico-hsm/pull/102, I noticed that my rp2350 doesn't wait for a button press when performing a python3 pico-hsm-tool.py bip32 sign operation. I have confirmed the setting is on with python3 pico-hsm-tool.py options get button.

I believe the BIP32 signing operation should be guarded by the hardware button, if enabled. While working on https://github.com/polhenarejos/pico-hsm/pull/102, I noticed that my rp2350 doesn't wait for a button press when performing a `python3 pico-hsm-tool.py bip32 sign` operation. I have confirmed the setting is on with `python3 pico-hsm-tool.py options get button`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 question
Further information is requested
 question
Further information is requested
 wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/pico-hsm#103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?