mistake in pico-hsm-tool.py #25

New Issue

2023-06-20T15:50:45+08:00

fchaxel commented

2023-06-20 15:50:45 +08:00

(Migrated from https://github.com/polhenarejos/pico-hsm)

Hi all,

Very good job ... an HSM module for 4 euros !

Line 114 it should be
parser._init.add_argument('--pin', help='PIN number')
not
parser.add_argument('--pin', help='PIN number')

Line 131 it should be
parser_rtc_get = subparser_rtc.add_parser('get', help='Gets the current datetime.')
not
parser_rtc_get = subparser_rtc.add_parser('set', help='Gets the current datetime.')

bye

Hi all, Very good job ... an HSM module for 4 euros ! Line 114 it should be **parser._init**.add_argument('--pin', help='PIN number') not **parser**.add_argument('--pin', help='PIN number') Line 131 it should be parser_rtc_get = subparser_rtc.add_parser('**get'**, help='Gets the current datetime.') not parser_rtc_get = subparser_rtc.add_parser(**'set',** help='Gets the current datetime.') bye

polhenarejos commented

2023-06-20 19:31:58 +08:00

(Migrated from https://github.com/polhenarejos/pico-hsm)

parser.add_argument('--pin', help='PIN number') is correct. --pin argument is available not only for initialization, but also for other commands. It is a common parameter for all.

Fixed rtc_get.

`parser.add_argument('--pin', help='PIN number')` is correct. `--pin` argument is available not only for initialization, but also for other commands. It is a common parameter for all. Fixed `rtc_get`.

fchaxel commented

2023-06-20 21:03:00 +08:00

(Migrated from https://github.com/polhenarejos/pico-hsm)

So in https://github.com/polhenarejos/pico-hsm/blob/master/doc/usage.md

$ python3 pico-hsm-tool.py initialize --so-pin 3537363231383830 --pin 648219

should be

$ python3 pico-hsm-tool.py --pin 648219 initialize --so-pin 3537363231383830

at the end of the command line --pin generates an error

HSM module work like a charm with XCA tool on Windows.

Bye

So in https://github.com/polhenarejos/pico-hsm/blob/master/doc/usage.md $ python3 pico-hsm-tool.py initialize --so-pin 3537363231383830 --pin 648219 should be $ python3 pico-hsm-tool.py --pin 648219 initialize --so-pin 3537363231383830 at the end of the command line --pin generates an error HSM module work like a charm with XCA tool on Windows. Bye

fchaxel commented

2023-06-22 12:16:23 +08:00

(Migrated from https://github.com/polhenarejos/pico-hsm)

Hi,

Back again with def parse_args(): in the script

In order to get the --pin args to be place after the command, and to use it with several sub command one can write something like this :

subparser = parser.add_subparsers(title="commands", dest="command")
parent = argparse.ArgumentParser(add_help=False)
parent.add_argument('--pin', help='PIN number')
parser_init = subparser.add_parser('initialize', help='Performs the first initialization of the Pico HSM.',parents=[parent])
parser_init.add_argument('--so-pin', help='SO-PIN number')

And you have to add the parameter parents=[parent] in each subcommand where the --pin argument can be use.

Bye.

Hi, Back again with def parse_args(): in the script In order to get the --pin args to be place after the command, and to use it with several sub command one can write something like this : subparser = parser.add_subparsers(title="commands", dest="command") parent = argparse.ArgumentParser(add_help=False) parent.add_argument('--pin', help='PIN number') parser_init = subparser.add_parser('initialize', help='Performs the first initialization of the Pico HSM.',parents=[parent]) parser_init.add_argument('--so-pin', help='SO-PIN number') And you have to add the parameter parents=[parent] in each subcommand where the --pin argument can be use. Bye.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dearsky/pico-hsm#25