dearsky/pico-hsm
1
0
Fork 0
Code Issues 17 Pull Requests 4 Actions Packages Projects Releases 26 Wiki Activity

LED Issue with generic RP2040 USB Device #71

New Issue
Closed
opened 2024-12-16 14:53:17 +08:00 by juliadin · 10 comments
juliadin commented 2024-12-16 14:53:17 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

I have a cheap USB Stick alike RP2040 device with 4MB Flash, used the raspberry pi eddsa image on it.

Using micropython on the same device, I can successfully blink the led on Pin 22 (and one I pinched to the board on Pin 29).

No matter how I provision the device, I can't get the LED to work or to put it differently: to do ANYTHING. The onboard LED just remains 'slightly on', exactly like after erasing the device.

I checked, and from what I gathered the rpi pico image should use the led_pico led_driver which seems also just set the given pin to OUT and control it.

I tried Pin 22, and 29 via the web based pico commissioner (what successfully commissioned the device) without avail...
The values show up correctly when querying via pico-hsm-tool.py from git.
I also tried to update the led_gpio via phy led_gpio and iterated over 0 to 40 without success.

Am I doing something wrong? Or is there somewhing weird about my device?

I got the same issue with the FIDO and OpenPGP firmware on this and an identical device.

I have a cheap USB Stick alike RP2040 device with 4MB Flash, used the raspberry pi eddsa image on it. Using micropython on the same device, I can successfully blink the led on Pin 22 (and one I pinched to the board on Pin 29). No matter how I provision the device, I can't get the LED to work or to put it differently: to do ANYTHING. The onboard LED just remains 'slightly on', exactly like after erasing the device. I checked, and from what I gathered the rpi pico image should use the `led_pico` led_driver which seems also just set the given pin to OUT and control it. I tried Pin 22, and 29 via the web based pico commissioner (what successfully commissioned the device) without avail... The values show up correctly when querying via `pico-hsm-tool.py` from git. I also tried to update the led_gpio via `phy led_gpio` and iterated over 0 to 40 without success. Am I doing something wrong? Or is there somewhing weird about my device? I got the same issue with the FIDO and OpenPGP firmware on this and an identical device.
juliadin commented 2024-12-16 14:56:10 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

phy value after setting pin 22 and restarting the key:

Current value: b'00105004070416050f060006'

phy value after setting pin 22 and restarting the key: `Current value: b'00105004070416050f060006'`
juliadin commented 2024-12-16 14:57:10 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

phy value after setting pin 29 and restarting the key:

Current value: b'0010500407041d050f060006'

phy value after setting pin 29 and restarting the key: `Current value: b'0010500407041d050f060006'`
polhenarejos commented 2024-12-16 16:24:50 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

Does this example work to you?

https://github.com/raspberrypi/pico-examples/tree/master/blink

Which firmware do you use? Are you sure it is the correct one for your board?

Does this example work to you? https://github.com/raspberrypi/pico-examples/tree/master/blink Which firmware do you use? Are you sure it is the correct one for your board?
juliadin commented 2024-12-16 17:33:04 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

Regarding the example: it works when I change PICO_DEFAULT_LED_PIN to 22 in the pico board and build it.

I use the 'pico' firmware official 5.0 build from the website - it seemed to match the board the most. I am in fact not sure that it is the right one but since I couldn't even find a board with GPIO 22 as the default LED pin I don't think there is a profile for that board yet.

It is a RP2040 with a Winbond W25Q32JV 32Mbit flash ... so it seemed a fair guess :/. I am also not really far in understanding the intricacies of pico-hsm on different boards.

In some other issue you mentioned that the difference in target boards is - apart from the led - mainly the flash size. Is there more to consider?

Regarding the example: it works when I change PICO_DEFAULT_LED_PIN to 22 in the pico board and build it. I use the 'pico' firmware official 5.0 build from the website - it seemed to match the board the most. I am in fact not sure that it is the right one but since I couldn't even find a board with GPIO 22 as the default LED pin I don't think there is a profile for that board yet. It is a RP2040 with a Winbond W25Q32JV 32Mbit flash ... so it seemed a fair guess :/. I am also not really far in understanding the intricacies of pico-hsm on different boards. In some other issue you mentioned that the difference in target boards is - apart from the led - mainly the flash size. Is there more to consider?
juliadin commented 2024-12-16 17:43:31 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

the LED works when I patch the pico.h to define PICO_DEFAULT_LED_PIN 22

what I don't understand is ... shouldn't the commissioner override this?

the LED works when I patch the pico.h to define `PICO_DEFAULT_LED_PIN 22` what I don't understand is ... shouldn't the commissioner override this?
polhenarejos commented 2024-12-16 17:52:23 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

Depending on the firmware you choose, it will use one driver or another. Do you have the model of your LED?

Depending on the firmware you choose, it will use one driver or another. Do you have the model of your LED?
juliadin commented 2024-12-16 18:46:09 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

the LED is a standard green LED (no integrated logic) attached to pin 22. As I said, when I use pico.h to build the pico-hsm firmware and change PICO_DEFAULT_LED_PIN to 22 it works with pico-hsm as well... It uses the led_pico driver so it just turns the pin on and off:

build $: cmake ../ -DVIDPID=NitroHSM -DPICO_BOARD=pico -DPICO_SDK_PATH=../pico-sdk/
PICO_SDK_PATH is /home/julia/src/pico-hsm/pico-sdk
Target board (PICO_BOARD) is 'pico'.
Using board configuration from /home/julia/src/pico-hsm/pico-sdk/src/boards/include/boards/pico.h
Pico Platform (PICO_PLATFORM) is 'rp2040'.
Build type is Release
TinyUSB available at /home/julia/src/pico-hsm/pico-sdk/lib/tinyusb/src/portable/raspberrypi/rp2040; enabling build support for USB.
BTstack available at /home/julia/src/pico-hsm/pico-sdk/lib/btstack
cyw43-driver available at /home/julia/src/pico-hsm/pico-sdk/lib/cyw43-driver
lwIP available at /home/julia/src/pico-hsm/pico-sdk/lib/lwip
mbedtls available at /home/julia/src/pico-hsm/pico-sdk/lib/mbedtls
-- VIDPID:			 'NitroHSM'
-- Delayed boot:		 disabled
-- USB CCID Interface:		 enabled
-- USB WebCCID Interface:	 enabled
-- USB VID/PID:			 0x20A0:0x4230
-- LED driver:			 led_pico
-- Found version:		 5.0
-- Configuring done
-- Generating done
-- Build files have been written to: /home/julia/src/pico-hsm/build_pico

Changing the LED pin via commissioning or the pico-hsm-tool.py doesn't seem to have any effect in that case as well. Should it?

the LED is a standard green LED (no integrated logic) attached to pin 22. As I said, when I use pico.h to build the pico-hsm firmware and change `PICO_DEFAULT_LED_PIN` to 22 it works with pico-hsm as well... It uses the led_pico driver so it just turns the pin on and off: ``` build $: cmake ../ -DVIDPID=NitroHSM -DPICO_BOARD=pico -DPICO_SDK_PATH=../pico-sdk/ PICO_SDK_PATH is /home/julia/src/pico-hsm/pico-sdk Target board (PICO_BOARD) is 'pico'. Using board configuration from /home/julia/src/pico-hsm/pico-sdk/src/boards/include/boards/pico.h Pico Platform (PICO_PLATFORM) is 'rp2040'. Build type is Release TinyUSB available at /home/julia/src/pico-hsm/pico-sdk/lib/tinyusb/src/portable/raspberrypi/rp2040; enabling build support for USB. BTstack available at /home/julia/src/pico-hsm/pico-sdk/lib/btstack cyw43-driver available at /home/julia/src/pico-hsm/pico-sdk/lib/cyw43-driver lwIP available at /home/julia/src/pico-hsm/pico-sdk/lib/lwip mbedtls available at /home/julia/src/pico-hsm/pico-sdk/lib/mbedtls -- VIDPID: 'NitroHSM' -- Delayed boot: disabled -- USB CCID Interface: enabled -- USB WebCCID Interface: enabled -- USB VID/PID: 0x20A0:0x4230 -- LED driver: led_pico -- Found version: 5.0 -- Configuring done -- Generating done -- Build files have been written to: /home/julia/src/pico-hsm/build_pico ``` Changing the LED pin via commissioning or the `pico-hsm-tool.py` doesn't seem to have any effect in that case as well. Should it?
polhenarejos commented 2024-12-16 20:06:04 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

You are right. There's a bug in the led_driver, as it takes the default one omitting the override. I'll push a fix.

You are right. There's a bug in the led_driver, as it takes the default one omitting the override. I'll push a fix.
❤️ 1
juliadin commented 2024-12-16 20:08:38 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

Thanks! - no further questions here then. If you don't want to track your fix in this issue, feel free to close it.

Thanks! - no further questions here then. If you don't want to track your fix in this issue, feel free to close it.
polhenarejos commented 2024-12-16 20:31:08 +08:00 (Migrated from https://github.com/polhenarejos/pico-hsm)
Copy Link

A fix is available at 07d9e22 in the development branch.
You can build yourself or wait for the nightly development build.

A fix is available at [07d9e22](https://github.com/polhenarejos/pico-hsm/commit/07d9e225d24aaf958dcd61d318725f599c3fd94a) in the `development` branch. You can build yourself or wait for the nightly development build.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 question
Further information is requested
 question
Further information is requested
 wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label bug good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/pico-hsm#71
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?