Fix race in test

Bump version, release notes
Remove upx for arm64/armv7, more translation credits
2022-03-30 14:37:42 -04:00 · 2022-03-30 14:26:31 -04:00 · 2022-03-30 14:23:57 -04:00 · 2022-03-30 10:01:16 -04:00 · 2022-03-29 15:40:26 -04:00 · 2022-03-29 11:47:56 -04:00
24 changed files with 381 additions and 494 deletions
--- a/.goreleaser.yml
+++ b/.goreleaser.yml
@@ -28,9 +28,8 @@ builds:
    goos: [linux]
    goarch: [arm]
    goarm: [7]
-    hooks:
-      post:
-        - upx "{{ .Path }}" # apt install upx
+    # No "upx", since it causes random core dumps, see
+    # https://github.com/binwiederhier/ntfy/issues/191#issuecomment-1083406546
  -
    id: ntfy_arm64
    binary: ntfy
@@ -42,9 +41,8 @@ builds:
      - "-linkmode=external -extldflags=-static -s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}}"
    goos: [linux]
    goarch: [arm64]
-    hooks:
-      post:
-        - upx "{{ .Path }}" # apt install upx
+    # No "upx", since it causes random core dumps, see
+    # https://github.com/binwiederhier/ntfy/issues/191#issuecomment-1083406546
 nfpms:
  -
    package_name: ntfy
--- a/README.md
+++ b/README.md
@@ -34,7 +34,14 @@ too.
 [Building](https://ntfy.sh/docs/develop/)

 ## Contributing
-I welcome any and all contributions. Just create a PR or an issue.
+I welcome any and all contributions. Just create a PR or an issue. To contribute code, check out 
+the [build instructions](https://ntfy.sh/docs/develop/) for the server and the Android app.
+Or, if you'd like to help translate 🇩🇪 🇺🇸 🇧🇬, you can start immediately in
+[Hosted Weblate](https://hosted.weblate.org/projects/ntfy/).
+
+<a href="https://hosted.weblate.org/engage/ntfy/">
+<img src="https://hosted.weblate.org/widgets/ntfy/-/multi-blue.svg" alt="Translation status" />
+</a>

 ## Contact me
 You can directly contact me **[on Discord](https://discord.gg/cT7ECsZj9w)** or [on Matrix](https://matrix.to/#/#ntfy:matrix.org) 
--- a/docs/config.md
+++ b/docs/config.md
@@ -346,7 +346,7 @@ statuspage.io (though these days most services also support webhooks and HTTP ca
 To configure the SMTP server, you must at least set `smtp-server-listen` and `smtp-server-domain`:

 * `smtp-server-listen` defines the IP address and port the SMTP server will listen on, e.g. `:25` or `1.2.3.4:25`
-* `smtp-server-domain` is the e-mail domain, e.g. `ntfy.sh`
+* `smtp-server-domain` is the e-mail domain, e.g. `ntfy.sh` (must be identical to MX record, see below)
 * `smtp-server-addr-prefix` is an optional prefix for the e-mail addresses to prevent spam. If set to `ntfy-`, for instance,
  only e-mails to `ntfy-$topic@ntfy.sh` will be accepted. If this is not set, all emails to `$topic@ntfy.sh` will be
  accepted (which may obviously be a spam problem).
@@ -369,6 +369,42 @@ configured (in [Amazon Route 53](https://aws.amazon.com/route53/)):
  <figcaption>DNS records for incoming mail</figcaption>
 </figure>

+You can check if everything is working correctly by sending an email as raw SMTP via `nc`. Create a text file, e.g. 
+`email.txt`
+
+```
+EHLO example.com
+MAIL FROM: phil@example.com
+RCPT TO: ntfy-mytopic@ntfy.sh
+DATA
+Subject: Email for you
+Content-Type: text/plain; charset="UTF-8"
+
+Hello from 🇩🇪
+.
+```
+
+And then send the mail via `nc` like this. If you see any lines starting with `451`, those are errors from the 
+ntfy server. Read them carefully.
+
+```
+$ cat email.txt | nc -N ntfy.sh 25
+220 ntfy.sh ESMTP Service Ready
+250-Hello example.com
+...
+250 2.0.0 Roger, accepting mail from <phil@example.com>
+250 2.0.0 I'll make sure <ntfy-mytopic@ntfy.sh> gets this
+```
+
+As for the DNS setup, be sure to verify that `dig MX` and `dig A` are returning results similar to this:
+
+```
+$ dig MX ntfy.sh +short 
+10 mx1.ntfy.sh.
+$ dig A mx1.ntfy.sh +short 
+3.139.215.220
+```
+
 ## Behind a proxy (TLS, etc.)
 !!! warning
    If you are running ntfy behind a proxy, you must set the `behind-proxy` flag. Otherwise, all visitors are
--- a/docs/deprecations.md
+++ b/docs/deprecations.md
@@ -10,6 +10,10 @@ This page is used to list deprecation notices for ntfy. Deprecated commands and
 In future versions of the Android app, instant delivery connections and connections to self-hosted servers will
 be using the WebSockets protocol. This potentially requires [configuration changes in your proxy](https://ntfy.sh/docs/config/#nginxapache2caddy).

+Due to [reports of varying battery consumption](https://github.com/binwiederhier/ntfy/issues/190) (which entirely 
+seems to depend on the phone), JSON HTTP stream support will not be removed. Instead, I'll just flip the default to 
+WebSocket in June.
+
 ### Android app: Using `since=<timestamp>` instead of `since=<id>`
 > Active since 2022-02-27, behavior will change in **May 2022**

--- a/docs/examples.md
+++ b/docs/examples.md
@@ -132,186 +132,213 @@ Some simple bash scripts to achieve this are kindly provided in [nickexyz's repo
 ## Node-RED
 You can use the HTTP request node to send messages with [Node-RED](https://nodered.org), some examples:

+
 <details>
-<summary>Example: Send a message</summary>
+<summary>Example: Send a message (click to expand)</summary>

 ```
 [
-  {
-    "id": "8f09d37dd5773f88",
-    "type": "http request",
-    "z": "ff3ad4e1.d3415",
-    "name": "ntfy",
-    "method": "POST",
-    "ret": "txt",
-    "paytoqs": "ignore",
-    "url": "https://example.com/topic",
-    "tls": "",
-    "persist": false,
-    "proxy": "",
-    "authType": "",
-    "senderr": false,
-    "credentials": {},
-    "x": 1410,
-    "y": 740,
-    "wires": [
-      []
-    ]
-  },
-  {
-    "id": "2603f296b25fe351",
-    "type": "function",
-    "z": "ff3ad4e1.d3415",
-    "name": "data",
-    "func": "msg.payload = \"Something happened\";\nmsg.headers = {};\nmsg.headers['tags'] = 'house';\nmsg.headers['X-Title'] = 'Home Assistant';\n\nreturn msg;",
-    "outputs": 1,
-    "noerr": 0,
-    "initialize": "",
-    "finalize": "",
-    "libs": [],
-    "x": 1290,
-    "y": 740,
-    "wires": [
-      [
-        "8f09d37dd5773f88"
-      ]
-    ]
-  },
-  {
-    "id": "d2351ed0720a239f",
-    "type": "inject",
-    "z": "ff3ad4e1.d3415",
-    "name": "Manual start",
-    "props": [
-      {
-        "p": "payload"
-      },
-      {
-        "p": "topic",
-        "vt": "str"
-      }
-    ],
-    "repeat": "",
-    "crontab": "",
-    "once": false,
-    "onceDelay": "20",
-    "topic": "",
-    "payload": "",
-    "payloadType": "date",
-    "x": 1150,
-    "y": 740,
-    "wires": [
-      [
-        "2603f296b25fe351"
-      ]
-    ]
-  }
+    {
+        "id": "c956e688cc74ad8e",
+        "type": "http request",
+        "z": "fabdd7a3.4045a",
+        "name": "ntfy.sh",
+        "method": "POST",
+        "ret": "txt",
+        "paytoqs": "ignore",
+        "url": "https://ntfy.sh/mytopic",
+        "tls": "",
+        "persist": false,
+        "proxy": "",
+        "authType": "",
+        "senderr": false,
+        "credentials":
+        {
+            "user": "",
+            "password": ""
+        },
+        "x": 590,
+        "y": 3160,
+        "wires":
+        [
+            []
+        ]
+    },
+    {
+        "id": "32ee1eade51fae50",
+        "type": "function",
+        "z": "fabdd7a3.4045a",
+        "name": "data",
+        "func": "msg.payload = \"Something happened\";\nmsg.headers = {};\nmsg.headers['tags'] = 'house';\nmsg.headers['X-Title'] = 'Home Assistant';\n\nreturn msg;",
+        "outputs": 1,
+        "noerr": 0,
+        "initialize": "",
+        "finalize": "",
+        "libs": [],
+        "x": 470,
+        "y": 3160,
+        "wires":
+        [
+            [
+                "c956e688cc74ad8e"
+            ]
+        ]
+    },
+    {
+        "id": "b287e59cd2311815",
+        "type": "inject",
+        "z": "fabdd7a3.4045a",
+        "name": "Manual start",
+        "props":
+        [
+            {
+                "p": "payload"
+            },
+            {
+                "p": "topic",
+                "vt": "str"
+            }
+        ],
+        "repeat": "",
+        "crontab": "",
+        "once": false,
+        "onceDelay": "20",
+        "topic": "",
+        "payload": "",
+        "payloadType": "date",
+        "x": 330,
+        "y": 3160,
+        "wires":
+        [
+            [
+                "32ee1eade51fae50"
+            ]
+        ]
+    }
 ]
 ```

 </details>

+![Node red message flow](static/img/nodered-message.png)
+
 <details>
-<summary>Example: Send a picture</summary>
+<summary>Example: Send a picture (click to expand)</summary>

 ```
 [
-  {
-    "id": "726d0d75d6c0f70e",
-    "type": "http request",
-    "z": "ff3ad4e1.d3415",
-    "name": "Download jpeg",
-    "method": "GET",
-    "ret": "bin",
-    "paytoqs": "ignore",
-    "url": "https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png",
-    "tls": "",
-    "persist": false,
-    "proxy": "",
-    "authType": "",
-    "senderr": false,
-    "credentials": {},
-    "x": 1320,
-    "y": 780,
-    "wires": [
-      [
-        "730dbbc9dbf1ed8a"
-      ]
-    ]
-  },
-  {
-    "id": "730dbbc9dbf1ed8a",
-    "type": "function",
-    "z": "ff3ad4e1.d3415",
-    "name": "data",
-    "func": "msg.payload = msg.payload;\nmsg.headers = {};\nmsg.headers['tags'] = 'house';\nmsg.headers['X-Title'] = 'Home Assistant - Picture';\n\nreturn msg;",
-    "outputs": 1,
-    "noerr": 0,
-    "initialize": "",
-    "finalize": "",
-    "libs": [],
-    "x": 1470,
-    "y": 780,
-    "wires": [
-      [
-        "592f424b37f76f5c"
-      ]
-    ]
-  },
-  {
-    "id": "592f424b37f76f5c",
-    "type": "http request",
-    "z": "ff3ad4e1.d3415",
-    "name": "ntfy",
-    "method": "PUT",
-    "ret": "bin",
-    "paytoqs": "ignore",
-    "url": "https://example.com/topic",
-    "tls": "",
-    "persist": false,
-    "proxy": "",
-    "authType": "",
-    "senderr": false,
-    "x": 1590,
-    "y": 780,
-    "wires": [
-      []
-    ]
-  },
-  {
-    "id": "8aa06dda3c902f6a",
-    "type": "inject",
-    "z": "ff3ad4e1.d3415",
-    "name": "Manual start",
-    "props": [
-      {
-        "p": "payload"
-      },
-      {
-        "p": "topic",
-        "vt": "str"
-      }
-    ],
-    "repeat": "",
-    "crontab": "",
-    "once": false,
-    "onceDelay": "20",
-    "topic": "",
-    "payload": "",
-    "payloadType": "date",
-    "x": 1150,
-    "y": 780,
-    "wires": [
-      [
-        "726d0d75d6c0f70e"
-      ]
-    ]
-  }
+    {
+        "id": "d135a13eadeb9d6d",
+        "type": "http request",
+        "z": "fabdd7a3.4045a",
+        "name": "Download image",
+        "method": "GET",
+        "ret": "bin",
+        "paytoqs": "ignore",
+        "url": "https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png",
+        "tls": "",
+        "persist": false,
+        "proxy": "",
+        "authType": "",
+        "senderr": false,
+        "credentials":
+        {
+            "user": "",
+            "password": ""
+        },
+        "x": 490,
+        "y": 3320,
+        "wires":
+        [
+            [
+                "6e75bc41d2ec4a03"
+            ]
+        ]
+    },
+    {
+        "id": "6e75bc41d2ec4a03",
+        "type": "function",
+        "z": "fabdd7a3.4045a",
+        "name": "data",
+        "func": "msg.payload = msg.payload;\nmsg.headers = {};\nmsg.headers['tags'] = 'house';\nmsg.headers['X-Title'] = 'Home Assistant - Picture';\n\nreturn msg;",
+        "outputs": 1,
+        "noerr": 0,
+        "initialize": "",
+        "finalize": "",
+        "libs": [],
+        "x": 650,
+        "y": 3320,
+        "wires":
+        [
+            [
+                "eb160615b6ceda98"
+            ]
+        ]
+    },
+    {
+        "id": "eb160615b6ceda98",
+        "type": "http request",
+        "z": "fabdd7a3.4045a",
+        "name": "ntfy.sh",
+        "method": "PUT",
+        "ret": "bin",
+        "paytoqs": "ignore",
+        "url": "https://ntfy.sh/mytopic",
+        "tls": "",
+        "persist": false,
+        "proxy": "",
+        "authType": "",
+        "senderr": false,
+        "credentials":
+        {
+            "user": "",
+            "password": ""
+        },
+        "x": 770,
+        "y": 3320,
+        "wires":
+        [
+            []
+        ]
+    },
+    {
+        "id": "5b8dbf15c8a7a3a5",
+        "type": "inject",
+        "z": "fabdd7a3.4045a",
+        "name": "Manual start",
+        "props":
+        [
+            {
+                "p": "payload"
+            },
+            {
+                "p": "topic",
+                "vt": "str"
+            }
+        ],
+        "repeat": "",
+        "crontab": "",
+        "once": false,
+        "onceDelay": "20",
+        "topic": "",
+        "payload": "",
+        "payloadType": "date",
+        "x": 310,
+        "y": 3320,
+        "wires":
+        [
+            [
+                "d135a13eadeb9d6d"
+            ]
+        ]
+    }
 ]
 ```

 </details>

+![Node red picture flow](static/img/nodered-picture.png)
+
 ## Gatus service health check

 An example for a custom alert with <a href="https://github.com/TwiN/gatus">Gatus</a>
--- a/docs/install.md
+++ b/docs/install.md
@@ -26,28 +26,28 @@ deb/rpm packages.

 === "x86_64/amd64"
    ```bash
-    wget https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_x86_64.tar.gz
-    tar zxvf ntfy_1.18.1_linux_x86_64.tar.gz
-    sudo cp -a ntfy_1.18.1_linux_x86_64/ntfy /usr/bin/ntfy
-    sudo mkdir /etc/ntfy && sudo cp ntfy_1.18.1_linux_x86_64/{client,server}/*.yml /etc/ntfy
+    wget https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_x86_64.tar.gz
+    tar zxvf ntfy_1.19.0_linux_x86_64.tar.gz
+    sudo cp -a ntfy_1.19.0_linux_x86_64/ntfy /usr/bin/ntfy
+    sudo mkdir /etc/ntfy && sudo cp ntfy_1.19.0_linux_x86_64/{client,server}/*.yml /etc/ntfy
    sudo ntfy serve
    ```

 === "armv7/armhf"
    ```bash
-    wget https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_armv7.tar.gz
-    tar zxvf ntfy_1.18.1_linux_armv7.tar.gz
-    sudo cp -a ntfy_1.18.1_linux_armv7/ntfy /usr/bin/ntfy
-    sudo mkdir /etc/ntfy && sudo cp ntfy_1.18.1_linux_armv7/{client,server}/*.yml /etc/ntfy
+    wget https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_armv7.tar.gz
+    tar zxvf ntfy_1.19.0_linux_armv7.tar.gz
+    sudo cp -a ntfy_1.19.0_linux_armv7/ntfy /usr/bin/ntfy
+    sudo mkdir /etc/ntfy && sudo cp ntfy_1.19.0_linux_armv7/{client,server}/*.yml /etc/ntfy
    sudo ntfy serve
    ```

 === "arm64"
    ```bash
-    wget https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_arm64.tar.gz
-    tar zxvf ntfy_1.18.1_linux_arm64.tar.gz
-    sudo cp -a ntfy_1.18.1_linux_arm64/ntfy /usr/bin/ntfy
-    sudo mkdir /etc/ntfy && sudo cp ntfy_1.18.1_linux_arm64/{client,server}/*.yml /etc/ntfy
+    wget https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_arm64.tar.gz
+    tar zxvf ntfy_1.19.0_linux_arm64.tar.gz
+    sudo cp -a ntfy_1.19.0_linux_arm64/ntfy /usr/bin/ntfy
+    sudo mkdir /etc/ntfy && sudo cp ntfy_1.19.0_linux_arm64/{client,server}/*.yml /etc/ntfy
    sudo ntfy serve
    ```

@@ -94,7 +94,7 @@ Manually installing the .deb file:

 === "x86_64/amd64"
    ```bash
-    wget https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_amd64.deb
+    wget https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_amd64.deb
    sudo dpkg -i ntfy_*.deb
    sudo systemctl enable ntfy
    sudo systemctl start ntfy
@@ -102,7 +102,7 @@ Manually installing the .deb file:

 === "armv7/armhf"
    ```bash
-    wget https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_armv7.deb
+    wget https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_armv7.deb
    sudo dpkg -i ntfy_*.deb
    sudo systemctl enable ntfy
    sudo systemctl start ntfy
@@ -110,7 +110,7 @@ Manually installing the .deb file:

 === "arm64"
    ```bash
-    wget https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_arm64.deb
+    wget https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_arm64.deb
    sudo dpkg -i ntfy_*.deb
    sudo systemctl enable ntfy
    sudo systemctl start ntfy
@@ -120,21 +120,21 @@ Manually installing the .deb file:

 === "x86_64/amd64"
    ```bash
-    sudo rpm -ivh https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_amd64.rpm
+    sudo rpm -ivh https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_amd64.rpm
    sudo systemctl enable ntfy 
    sudo systemctl start ntfy
    ```

 === "armv7/armhf"
    ```bash
-    sudo rpm -ivh https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_armv7.rpm
+    sudo rpm -ivh https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_armv7.rpm
    sudo systemctl enable ntfy 
    sudo systemctl start ntfy
    ```

 === "arm64"
    ```bash
-    sudo rpm -ivh https://github.com/binwiederhier/ntfy/releases/download/v1.18.1/ntfy_1.18.1_linux_arm64.rpm
+    sudo rpm -ivh https://github.com/binwiederhier/ntfy/releases/download/v1.19.0/ntfy_1.19.0_linux_arm64.rpm
    sudo systemctl enable ntfy 
    sudo systemctl start ntfy
    ```
@@ -194,13 +194,3 @@ COPY server.yml /etc/ntfy/server.yml
 ENTRYPOINT ["ntfy", "serve"]
 ```
 This image can be pushed to a container registry and shipped independently. All that's needed when running it is mapping ntfy's port to a host port.
-
-## Go
-To install via Go, simply run:
-```bash
-go install heckel.io/ntfy@latest
-```
-
-!!! info
-    Please [let me know](https://github.com/binwiederhier/ntfy/issues) if there are any issues with this installation
-    method. The SQLite bindings require CGO and it works for me, but I have the feeling it may not work for everyone.
--- a/docs/publish.md
+++ b/docs/publish.md
@@ -661,7 +661,8 @@ the example.
    To publish as JSON, you must **PUT/POST to the ntfy root URL**, not to the topic URL. Be sure to check that you're
    POST-ing to `https://ntfy.sh/` (correct), and not to `https://ntfy.sh/mytopic` (incorrect). 

-Here's an example using all supported parameters. The `topic` parameter is the only required one:
+Here's an example using most supported parameters. Check the table below for a complete list. The `topic` parameter 
+is the only required one:

 === "Command line (curl)"
    ```
@@ -798,7 +799,8 @@ all the supported fields:
 | `click`    | -        | *URL*                            | `https://example.com`          | Website opened when notification is [clicked](#click-action)          |
 | `attach`   | -        | *URL*                            | `https://example.com/file.jpg` | URL of an attachment, see [attach via URL](#attach-file-from-url)     |
 | `filename` | -        | *string*                         | `file.jpg`                     | File name of the attachment                                           |
-
+| `delay`    | -        | *string*                         | `30min`, `9am`                 | Timestamp or duration for delayed delivery                            |
+| `email`    | -        | *e-mail address*                 | `phil@example.com`             | E-mail address for e-mail notifications                               |

 ## Click action
 You can define which URL to open when a notification is clicked. This may be useful if your notification is related 
--- a/docs/releases.md
+++ b/docs/releases.md
@@ -10,6 +10,8 @@ and the [ntfy Android app](https://github.com/binwiederhier/ntfy-android/release

 * Download attachments to cache folder ([#181](https://github.com/binwiederhier/ntfy/issues/181))
 * Regularly delete attachments for deleted notifications ([#142](https://github.com/binwiederhier/ntfy/issues/142))
+* Translations to different languages ([#188](https://github.com/binwiederhier/ntfy/issues/188), thanks to 
+  [@StoyanDimitrov](https://github.com/StoyanDimitrov) for initiating things)

 **Bugs:**

@@ -17,18 +19,41 @@ and the [ntfy Android app](https://github.com/binwiederhier/ntfy-android/release
 * SQLiteConstraintException: Crash during UP registration ([#185](https://github.com/binwiederhier/ntfy/issues/185))
 * Refresh preferences screen after settings import (#183, thanks to [@cmeis](https://github.com/cmeis) for reporting)

+**Translations:**
+
+* English language improvements (thanks to [@comradekingu](https://github.com/comradekingu))
+* Bulgarian (thanks to [@StoyanDimitrov](https://github.com/StoyanDimitrov)) 
+* Chinese/Simplified (thanks to [@poi](https://hosted.weblate.org/user/poi) and [@PeterCxy](https://hosted.weblate.org/user/PeterCxy))
+* Dutch (*incomplete*, thanks to [@diony](https://hosted.weblate.org/user/diony))
+* French (*incomplete*, thanks to [@Kusoneko](https://kusoneko.moe/))
+* German (thanks to [@cmeis](https://github.com/cmeis))
+* Italian (thanks to [@theTranslator](https://hosted.weblate.org/user/theTranslator/))
+* Norwegian (*incomplete*, thanks to [@comradekingu](https://github.com/comradekingu))
+* Portuguese/Brazil (thanks to [@LW](https://hosted.weblate.org/user/LW/))
+* Spanish (thanks to [@rogeliodh](https://github.com/rogeliodh))
+* Turkish (thanks to [@ersen](https://ersen.moe/))
+
 **Thanks:**

 * Many thanks to [@cmeis](https://github.com/cmeis), [@Fallenbagel](https://github.com/Fallenbagel), [@Joeharrison94](https://github.com/Joeharrison94),
  and [@rogeliodh](https://github.com/rogeliodh) for input on the new attachment logic, and for testing the release

-## ntfy server v1.19.0 (UNRELEASED)
+-->
+
+## ntfy server v1.19.0
+Released Mar 30, 2022

 **Bugs:**

-* Do not allow comma in topic name in publish via GET endpoint (no ticket) 
+* Do not pack binary with `upx` for armv7/arm64 due to `illegal instruction` errors ([#191](https://github.com/binwiederhier/ntfy/issues/191), thanks to [@iexos](https://github.com/iexos))
+* Do not allow comma in topic name in publish via GET endpoint (no ticket)
+* Add "Access-Control-Allow-Origin: *" for attachments (no ticket, thanks to @FrameXX)
+* Make pruning run again in web app ([#186](https://github.com/binwiederhier/ntfy/issues/186))
+* Added missing params `delay` and `email` to publish as JSON body (no ticket)

-->
+**Documentation:**
+
+* Improved [e-mail publishing](config.md#e-mail-publishing) documentation

 ## ntfy server v1.18.1
 Released Mar 21, 2022   
--- a/docs/static/img/nodered-message.png
+++ b/docs/static/img/nodered-message.png
--- a/docs/static/img/nodered-picture.png
+++ b/docs/static/img/nodered-picture.png
--- a/server/errors.go
+++ b/server/errors.go
@@ -40,16 +40,14 @@ var (
 	errHTTPBadRequestAttachmentsExpiryBeforeDelivery = &errHTTP{40015, http.StatusBadRequest, "invalid request: attachment expiry before delayed delivery date", "https://ntfy.sh/docs/publish/#scheduled-delivery"}
 	errHTTPBadRequestWebSocketsUpgradeHeaderMissing  = &errHTTP{40016, http.StatusBadRequest, "invalid request: client not using the websocket protocol", "https://ntfy.sh/docs/subscribe/api/#websockets"}
 	errHTTPBadRequestJSONInvalid                     = &errHTTP{40017, http.StatusBadRequest, "invalid request: request body must be message JSON", "https://ntfy.sh/docs/publish/#publish-as-json"}
-	errHTTPNotFound                                  = &errHTTP{40401, http.StatusNotFound, "not found", ""}
-	errHTTPNotFoundMessageID                         = &errHTTP{40402, http.StatusNotFound, "not found: unable to find message with this ID", "https://ntfy.sh/docs/publish/#updating-messages"} // FIXME LINK
+	errHTTPNotFound                                  = &errHTTP{40401, http.StatusNotFound, "page not found", ""}
 	errHTTPUnauthorized                              = &errHTTP{40101, http.StatusUnauthorized, "unauthorized", "https://ntfy.sh/docs/publish/#authentication"}
 	errHTTPForbidden                                 = &errHTTP{40301, http.StatusForbidden, "forbidden", "https://ntfy.sh/docs/publish/#authentication"}
 	errHTTPTooManyRequestsLimitRequests              = &errHTTP{42901, http.StatusTooManyRequests, "limit reached: too many requests, please be nice", "https://ntfy.sh/docs/publish/#limitations"}
 	errHTTPTooManyRequestsLimitEmails                = &errHTTP{42902, http.StatusTooManyRequests, "limit reached: too many emails, please be nice", "https://ntfy.sh/docs/publish/#limitations"}
 	errHTTPTooManyRequestsLimitSubscriptions         = &errHTTP{42903, http.StatusTooManyRequests, "limit reached: too many active subscriptions, please be nice", "https://ntfy.sh/docs/publish/#limitations"}
 	errHTTPTooManyRequestsLimitTotalTopics           = &errHTTP{42904, http.StatusTooManyRequests, "limit reached: the total number of topics on the server has been reached, please contact the admin", "https://ntfy.sh/docs/publish/#limitations"}
-	errHTTPTooManyRequestsAttachmentBandwidthLimit   = &errHTTP{42905, http.StatusTooManyRequests, "limit reached: daily bandwidth limit reached, please be nice", "https://ntfy.sh/docs/publish/#limitations"}
-	errHTTPTooManyRequestsUpdatingTooQuickly         = &errHTTP{42906, http.StatusTooManyRequests, "limit reached: too many consecutive message updates", "https://ntfy.sh/docs/publish/#updating-messages"} // FIXME LINK
+	errHTTPTooManyRequestsAttachmentBandwidthLimit   = &errHTTP{42905, http.StatusTooManyRequests, "too many requests: daily bandwidth limit reached", "https://ntfy.sh/docs/publish/#limitations"}
 	errHTTPInternalError                             = &errHTTP{50001, http.StatusInternalServerError, "internal server error", ""}
 	errHTTPInternalErrorInvalidFilePath              = &errHTTP{50002, http.StatusInternalServerError, "internal server error: invalid file path", ""}
 )
--- a/server/message_cache.go
+++ b/server/message_cache.go
@@ -23,7 +23,6 @@ const (
 			id INTEGER PRIMARY KEY AUTOINCREMENT,
 			mid TEXT NOT NULL,
 			time INT NOT NULL,
-			updated INT NOT NULL,
 			topic TEXT NOT NULL,
 			message TEXT NOT NULL,
 			title TEXT NOT NULL,
@@ -44,47 +43,41 @@ const (
 		COMMIT;
 	`
 	insertMessageQuery = `
-		INSERT INTO messages (mid, time, updated, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding, published) 
-		VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+		INSERT INTO messages (mid, time, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding, published) 
+		VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
 	`
-	updateMessageQuery           = `UPDATE messages SET updated = ?, message = ?, title = ?, priority = ?, tags = ?, click = ? WHERE topic = ? AND mid = ?`
 	pruneMessagesQuery           = `DELETE FROM messages WHERE time < ? AND published = 1`
 	selectRowIDFromMessageID     = `SELECT id FROM messages WHERE topic = ? AND mid = ?`
 	selectMessagesSinceTimeQuery = `
-		SELECT mid, time, updated, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
+		SELECT mid, time, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
 		FROM messages 
 		WHERE topic = ? AND time >= ? AND published = 1
 		ORDER BY time, id
 	`
 	selectMessagesSinceTimeIncludeScheduledQuery = `
-		SELECT mid, time, updated, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
+		SELECT mid, time, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
 		FROM messages 
 		WHERE topic = ? AND time >= ?
 		ORDER BY time, id
 	`
 	selectMessagesSinceIDQuery = `
-		SELECT mid, time, updated, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
+		SELECT mid, time, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
 		FROM messages 
-		WHERE topic = ? AND id >= ? AND published = 1 
+		WHERE topic = ? AND id > ? AND published = 1 
 		ORDER BY time, id
 	`
 	selectMessagesSinceIDIncludeScheduledQuery = `
-		SELECT mid, time, updated, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
+		SELECT mid, time, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
 		FROM messages 
-		WHERE topic = ? AND (id >= ? OR published = 0)
+		WHERE topic = ? AND (id > ? OR published = 0)
 		ORDER BY time, id
 	`
 	selectMessagesDueQuery = `
-		SELECT mid, time, updated, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
+		SELECT mid, time, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
 		FROM messages 
 		WHERE time <= ? AND published = 0
 		ORDER BY time, id
 	`
-	selectMessageByIDQuery = `
-		SELECT mid, time, updated, topic, message, title, priority, tags, click, attachment_name, attachment_type, attachment_size, attachment_expires, attachment_url, attachment_owner, encoding
-		FROM messages 
-		WHERE topic = ? AND mid = ?
-	`
 	updateMessagePublishedQuery     = `UPDATE messages SET published = 1 WHERE mid = ?`
 	selectMessagesCountQuery        = `SELECT COUNT(*) FROM messages`
 	selectMessageCountForTopicQuery = `SELECT COUNT(*) FROM messages WHERE topic = ?`
@@ -95,7 +88,7 @@ const (

 // Schema management queries
 const (
-	currentSchemaVersion          = 6
+	currentSchemaVersion          = 5
 	createSchemaVersionTableQuery = `
 		CREATE TABLE IF NOT EXISTS schemaVersion (
 			id INT PRIMARY KEY,
@@ -173,11 +166,6 @@ const (
 		ALTER TABLE messages_new RENAME TO messages;
 		COMMIT;
 	`
-
-	// 5 -> 6
-	migrate5To6AlterMessagesTableQuery = `
-		ALTER TABLE messages ADD COLUMN updated INT NOT NULL DEFAULT (0);
-	`
 )

 type messageCache struct {
@@ -244,7 +232,6 @@ func (c *messageCache) AddMessage(m *message) error {
 		insertMessageQuery,
 		m.ID,
 		m.Time,
-		m.Updated,
 		m.Topic,
 		m.Message,
 		m.Title,
@@ -263,28 +250,6 @@ func (c *messageCache) AddMessage(m *message) error {
 	return err
 }

-func (c *messageCache) UpdateMessage(m *message) error {
-	if m.Event != messageEvent {
-		return errUnexpectedMessageType
-	}
-	if c.nop {
-		return nil
-	}
-	tags := strings.Join(m.Tags, ",")
-	_, err := c.db.Exec(
-		updateMessageQuery,
-		m.Updated,
-		m.Message,
-		m.Title,
-		m.Priority,
-		tags,
-		m.Click,
-		m.Topic,
-		m.ID,
-	)
-	return err
-}
-
 func (c *messageCache) Messages(topic string, since sinceMarker, scheduled bool) ([]*message, error) {
 	if since.IsNone() {
 		return make([]*message, 0), nil
@@ -331,15 +296,7 @@ func (c *messageCache) messagesSinceID(topic string, since sinceMarker, schedule
 	if err != nil {
 		return nil, err
 	}
-	messages, err := readMessages(rows)
-	if err != nil {
-		return nil, err
-	} else if len(messages) == 0 {
-		return messages, nil
-	} else if since.IsTime() && messages[0].Updated > since.Time().Unix() {
-		return messages, nil
-	}
-	return messages[1:], nil // Do not include row with ID itself
+	return readMessages(rows)
 }

 func (c *messageCache) MessagesDue() ([]*message, error) {
@@ -436,31 +393,16 @@ func (c *messageCache) AttachmentsExpired() ([]string, error) {
 	return ids, nil
 }

-func (c *messageCache) Message(topic, id string) (*message, error) {
-	rows, err := c.db.Query(selectMessageByIDQuery, topic, id)
-	if err != nil {
-		return nil, err
-	}
-	messages, err := readMessages(rows)
-	if err != nil {
-		return nil, err
-	} else if len(messages) == 0 {
-		return nil, errors.New("not found")
-	}
-	return messages[0], nil
-}
-
 func readMessages(rows *sql.Rows) ([]*message, error) {
 	defer rows.Close()
 	messages := make([]*message, 0)
 	for rows.Next() {
-		var timestamp, updated, attachmentSize, attachmentExpires int64
+		var timestamp, attachmentSize, attachmentExpires int64
 		var priority int
 		var id, topic, msg, title, tagsStr, click, attachmentName, attachmentType, attachmentURL, attachmentOwner, encoding string
 		err := rows.Scan(
 			&id,
 			&timestamp,
-			&updated,
 			&topic,
 			&msg,
 			&title,
@@ -496,7 +438,6 @@ func readMessages(rows *sql.Rows) ([]*message, error) {
 		messages = append(messages, &message{
 			ID:         id,
 			Time:       timestamp,
-			Updated:    updated,
 			Event:      messageEvent,
 			Topic:      topic,
 			Message:    msg,
@@ -549,8 +490,6 @@ func setupCacheDB(db *sql.DB) error {
 		return migrateFrom3(db)
 	} else if schemaVersion == 4 {
 		return migrateFrom4(db)
-	} else if schemaVersion == 5 {
-		return migrateFrom5(db)
 	}
 	return fmt.Errorf("unexpected schema version found: %d", schemaVersion)
 }
@@ -623,16 +562,5 @@ func migrateFrom4(db *sql.DB) error {
 	if _, err := db.Exec(updateSchemaVersion, 5); err != nil {
 		return err
 	}
-	return migrateFrom5(db)
-}
-
-func migrateFrom5(db *sql.DB) error {
-	log.Print("Migrating cache database schema: from 5 to 6")
-	if _, err := db.Exec(migrate5To6AlterMessagesTableQuery); err != nil {
-		return err
-	}
-	if _, err := db.Exec(updateSchemaVersion, 6); err != nil {
-		return err
-	}
 	return nil // Update this when a new version is added
 }
--- a/server/server.go
+++ b/server/server.go
@@ -55,10 +55,9 @@ type handleFunc func(http.ResponseWriter, *http.Request, *visitor) error

 var (
 	// If changed, don't forget to update Android App and auth_sqlite.go
-	topicRegex             = regexp.MustCompile(`^[-_A-Za-z0-9]{1,64}$`)                  // No /!
-	topicPathRegex         = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}$`)                 // Regex must match JS & Android app!
-	updateTopicPathRegex   = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}/[A-Za-z0-9]{12}$`) // ID length must match messageIDLength & util.randomStringCharset
-	externalTopicPathRegex = regexp.MustCompile(`^/[^/]+\.[^/]+/[-_A-Za-z0-9]{1,64}$`)    // Extended topic path, for web-app, e.g. /example.com/mytopic
+	topicRegex             = regexp.MustCompile(`^[-_A-Za-z0-9]{1,64}$`)               // No /!
+	topicPathRegex         = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}$`)              // Regex must match JS & Android app!
+	externalTopicPathRegex = regexp.MustCompile(`^/[^/]+\.[^/]+/[-_A-Za-z0-9]{1,64}$`) // Extended topic path, for web-app, e.g. /example.com/mytopic
 	jsonPathRegex          = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}(,[-_A-Za-z0-9]{1,64})*/json$`)
 	ssePathRegex           = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}(,[-_A-Za-z0-9]{1,64})*/sse$`)
 	rawPathRegex           = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}(,[-_A-Za-z0-9]{1,64})*/raw$`)
@@ -280,7 +279,7 @@ func (s *Server) handleInternal(w http.ResponseWriter, r *http.Request, v *visit
 		return s.handleOptions(w, r)
 	} else if (r.Method == http.MethodPut || r.Method == http.MethodPost) && r.URL.Path == "/" {
 		return s.limitRequests(s.transformBodyJSON(s.authWrite(s.handlePublish)))(w, r, v)
-	} else if (r.Method == http.MethodPut || r.Method == http.MethodPost) && (topicPathRegex.MatchString(r.URL.Path) || updateTopicPathRegex.MatchString(r.URL.Path)) {
+	} else if (r.Method == http.MethodPut || r.Method == http.MethodPost) && topicPathRegex.MatchString(r.URL.Path) {
 		return s.limitRequests(s.authWrite(s.handlePublish))(w, r, v)
 	} else if r.Method == http.MethodGet && publishPathRegex.MatchString(r.URL.Path) {
 		return s.limitRequests(s.authWrite(s.handlePublish))(w, r, v)
@@ -381,6 +380,7 @@ func (s *Server) handleFile(w http.ResponseWriter, r *http.Request, v *visitor)
 		return errHTTPTooManyRequestsAttachmentBandwidthLimit
 	}
 	w.Header().Set("Content-Length", fmt.Sprintf("%d", stat.Size()))
+	w.Header().Set("Access-Control-Allow-Origin", "*") // CORS, allow cross-origin requests
 	f, err := os.Open(file)
 	if err != nil {
 		return err
@@ -391,26 +391,7 @@ func (s *Server) handleFile(w http.ResponseWriter, r *http.Request, v *visitor)
 }

 func (s *Server) handlePublish(w http.ResponseWriter, r *http.Request, v *visitor) error {
-	t, messageID, err := s.topicAndMessageIDFromPath(r.URL.Path)
-	if err != nil {
-		return err
-	}
-	var m *message
-	update := messageID != ""
-	if update {
-		m, err = s.messageCache.Message(t.ID, messageID)
-		if err != nil {
-			return errHTTPNotFoundMessageID
-		}
-		newUpdated := time.Now().Unix()
-		if newUpdated <= m.Updated {
-			return errHTTPTooManyRequestsUpdatingTooQuickly
-		}
-		m.Updated = newUpdated
-	} else {
-		m = newDefaultMessage(t.ID, "")
-	}
-	cache, firebase, email, unifiedpush, err := s.parsePublishParams(r, v, m)
+	t, err := s.topicFromPath(r.URL.Path)
 	if err != nil {
 		return err
 	}
@@ -418,6 +399,11 @@ func (s *Server) handlePublish(w http.ResponseWriter, r *http.Request, v *visito
 	if err != nil {
 		return err
 	}
+	m := newDefaultMessage(t.ID, "")
+	cache, firebase, email, unifiedpush, err := s.parsePublishParams(r, v, m)
+	if err != nil {
+		return err
+	}
 	if err := s.handlePublishBody(r, v, m, body, unifiedpush); err != nil {
 		return err
 	}
@@ -445,14 +431,8 @@ func (s *Server) handlePublish(w http.ResponseWriter, r *http.Request, v *visito
 		}()
 	}
 	if cache {
-		if update {
-			if err := s.messageCache.UpdateMessage(m); err != nil {
-				return err
-			}
-		} else {
-			if err := s.messageCache.AddMessage(m); err != nil {
-				return err
-			}
+		if err := s.messageCache.AddMessage(m); err != nil {
+			return err
 		}
 	}
 	w.Header().Set("Content-Type", "application/json")
@@ -468,19 +448,9 @@ func (s *Server) handlePublish(w http.ResponseWriter, r *http.Request, v *visito

 func (s *Server) parsePublishParams(r *http.Request, v *visitor, m *message) (cache bool, firebase bool, email string, unifiedpush bool, err error) {
 	cache = readBoolParam(r, true, "x-cache", "cache")
-	if !cache && m.Updated != 0 {
-		return false, false, "", false, errors.New("message updates must be cached")
-	}
-	// TODO more restrictions
 	firebase = readBoolParam(r, true, "x-firebase", "firebase")
-	title := readParam(r, "x-title", "title", "t")
-	if title != "" {
-		m.Title = title
-	}
-	click := readParam(r, "x-click", "click")
-	if click != "" {
-		m.Click = click
-	}
+	m.Title = readParam(r, "x-title", "title", "t")
+	m.Click = readParam(r, "x-click", "click")
 	filename := readParam(r, "x-filename", "filename", "file", "f")
 	attach := readParam(r, "x-attach", "attach", "a")
 	if attach != "" || filename != "" {
@@ -520,11 +490,9 @@ func (s *Server) parsePublishParams(r *http.Request, v *visitor, m *message) (ca
 	if messageStr != "" {
 		m.Message = messageStr
 	}
-	priority, err := util.ParsePriority(readParam(r, "x-priority", "priority", "prio", "p"))
+	m.Priority, err = util.ParsePriority(readParam(r, "x-priority", "priority", "prio", "p"))
 	if err != nil {
 		return false, false, "", false, errHTTPBadRequestPriorityInvalid
-	} else if priority > 0 {
-		m.Priority = priority
 	}
 	tagsStr := readParam(r, "x-tags", "tags", "tag", "ta")
 	if tagsStr != "" {
@@ -903,13 +871,6 @@ func parseSince(r *http.Request, poll bool) (sinceMarker, error) {
 		return sinceNoMessages, nil
 	}

-	// ID/timestamp
-	parts := strings.Split(since, "/")
-	if len(parts) == 2 && validMessageID(parts[0]) && validUnixTimestamp(parts[1]) {
-		t, _ := toUnixTimestamp(parts[1])
-		return newSince(parts[0], t), nil
-	}
-
 	// ID, timestamp, duration
 	if validMessageID(since) {
 		return newSinceID(since), nil
@@ -928,20 +889,16 @@ func (s *Server) handleOptions(w http.ResponseWriter, _ *http.Request) error {
 	return nil
 }

-func (s *Server) topicAndMessageIDFromPath(path string) (*topic, string, error) {
+func (s *Server) topicFromPath(path string) (*topic, error) {
 	parts := strings.Split(path, "/")
-	if len(parts) != 2 && len(parts) != 3 {
-		return nil, "", errHTTPBadRequestTopicInvalid
+	if len(parts) < 2 {
+		return nil, errHTTPBadRequestTopicInvalid
 	}
 	topics, err := s.topicsFromIDs(parts[1])
 	if err != nil {
-		return nil, "", err
+		return nil, err
 	}
-	messageID := ""
-	if len(parts) == 3 && len(parts[2]) == messageIDLength {
-		messageID = parts[2]
-	}
-	return topics[0], messageID, nil
+	return topics[0], nil
 }

 func (s *Server) topicsFromPath(path string) ([]*topic, string, error) {
@@ -1178,6 +1135,12 @@ func (s *Server) transformBodyJSON(next handleFunc) handleFunc {
 		if m.Click != "" {
 			r.Header.Set("X-Click", m.Click)
 		}
+		if m.Email != "" {
+			r.Header.Set("X-Email", m.Email)
+		}
+		if m.Delay != "" {
+			r.Header.Set("X-Delay", m.Delay)
+		}
 		return next(w, r, v)
 	}
 }
--- a/server/server_firebase.go
+++ b/server/server_firebase.go
@@ -72,7 +72,6 @@ func toFirebaseMessage(m *message, auther auth.Auther) (*messaging.Message, erro
 			data = map[string]string{
 				"id":       m.ID,
 				"time":     fmt.Sprintf("%d", m.Time),
-				"updated":  fmt.Sprintf("%d", m.Updated),
 				"event":    m.Event,
 				"topic":    m.Topic,
 				"priority": fmt.Sprintf("%d", m.Priority),
--- a/server/server_firebase_test.go
+++ b/server/server_firebase_test.go
@@ -77,7 +77,6 @@ func TestToFirebaseMessage_Message_Normal_Allowed(t *testing.T) {
 	require.Equal(t, map[string]string{
 		"id":                 m.ID,
 		"time":               fmt.Sprintf("%d", m.Time),
-		"updated":            "0",
 		"event":              "message",
 		"topic":              "mytopic",
 		"priority":           "4",
--- a/server/server_test.go
+++ b/server/server_test.go
@@ -390,69 +390,6 @@ func TestServer_PublishAndPollSince(t *testing.T) {
 	require.Equal(t, 40008, toHTTPError(t, response.Body.String()).Code)
 }

-func TestServer_PublishUpdateAndPollSince(t *testing.T) {
-	s := newTestServer(t, newTestConfig(t))
-
-	// Initial PUT
-	response := request(t, s, "PUT", "/mytopic?t=atitle&tags=tag1,tag2&prio=high&click=https://google.com&attach=https://heckel.io", "test 1", nil)
-	message1 := toMessage(t, response.Body.String())
-	require.Equal(t, int64(0), message1.Updated)
-	require.Equal(t, "test 1", message1.Message)
-	require.Equal(t, "atitle", message1.Title)
-	require.Equal(t, 4, message1.Priority)
-	require.Equal(t, []string{"tag1", "tag2"}, message1.Tags)
-	require.Equal(t, "https://google.com", message1.Click)
-	require.Equal(t, "https://heckel.io", message1.Attachment.URL)
-
-	// Update
-	response = request(t, s, "PUT", "/mytopic/"+message1.ID+"?prio=low", "test 2", nil)
-	message2 := toMessage(t, response.Body.String())
-	require.Equal(t, message1.ID, message2.ID)
-	require.True(t, message2.Updated > message1.Updated)
-	require.Equal(t, "test 2", message2.Message) // Updated
-	require.Equal(t, "atitle", message2.Title)
-	require.Equal(t, 2, message2.Priority) // Updated
-	require.Equal(t, []string{"tag1", "tag2"}, message2.Tags)
-	require.Equal(t, "https://google.com", message2.Click)
-	require.Equal(t, "https://heckel.io", message2.Attachment.URL)
-
-	time.Sleep(1100 * time.Millisecond)
-
-	// Another update
-	response = request(t, s, "PUT", "/mytopic/"+message1.ID+"?title=new+title", "test 3", nil)
-	message3 := toMessage(t, response.Body.String())
-	require.True(t, message3.Updated > message2.Updated)
-	require.Equal(t, "test 3", message3.Message)  // Updated
-	require.Equal(t, "new title", message3.Title) // Updated
-
-	// Get all messages: Should be only one that was updated
-	since := "all"
-	response = request(t, s, "GET", "/mytopic/json?since="+since+"&poll=1", "", nil)
-	messages := toMessages(t, response.Body.String())
-	require.Equal(t, 1, len(messages))
-	require.Equal(t, message1.ID, messages[0].ID)
-	require.Equal(t, "test 3", messages[0].Message)
-
-	// Get all messages since "message ID": Should be zero, since we know this message
-	since = message1.ID
-	response = request(t, s, "GET", "/mytopic/json?since="+since+"&poll=1", "", nil)
-	messages = toMessages(t, response.Body.String())
-	require.Equal(t, 0, len(messages))
-
-	// Get all messages since "message ID" but with an older timestamp: Should be the latest updated message
-	since = fmt.Sprintf("%s/%d", message1.ID, message2.Updated) // We're missing an update
-	response = request(t, s, "GET", "/mytopic/json?since="+since+"&poll=1", "", nil)
-	messages = toMessages(t, response.Body.String())
-	require.Equal(t, 1, len(messages))
-	require.Equal(t, "test 3", messages[0].Message)
-
-	// Get all messages since "message ID" with the current timestamp: No messages expected
-	since = fmt.Sprintf("%s/%d", message3.ID, message3.Updated) // We are up-to-date
-	response = request(t, s, "GET", "/mytopic/json?since="+since+"&poll=1", "", nil)
-	messages = toMessages(t, response.Body.String())
-	require.Equal(t, 0, len(messages))
-}
-
 func TestServer_PublishViaGET(t *testing.T) {
 	s := newTestServer(t, newTestConfig(t))

@@ -777,6 +714,12 @@ func (t *testMailer) Send(from, to string, m *message) error {
 	return nil
 }

+func (t *testMailer) Count() int {
+	t.mu.Lock()
+	defer t.mu.Unlock()
+	return t.count
+}
+
 func TestServer_PublishTooRequests_Defaults(t *testing.T) {
 	s := newTestServer(t, newTestConfig(t))
 	for i := 0; i < 60; i++ {
@@ -936,7 +879,8 @@ func TestServer_PublishUnifiedPushText(t *testing.T) {
 func TestServer_PublishAsJSON(t *testing.T) {
 	s := newTestServer(t, newTestConfig(t))
 	body := `{"topic":"mytopic","message":"A message","title":"a title\nwith lines","tags":["tag1","tag 2"],` +
-		`"not-a-thing":"ok", "attach":"http://google.com","filename":"google.pdf", "click":"http://ntfy.sh","priority":4}`
+		`"not-a-thing":"ok", "attach":"http://google.com","filename":"google.pdf", "click":"http://ntfy.sh","priority":4,` +
+		`"delay":"30min"}`
 	response := request(t, s, "PUT", "/", body, nil)
 	require.Equal(t, 200, response.Code)

@@ -949,6 +893,22 @@ func TestServer_PublishAsJSON(t *testing.T) {
 	require.Equal(t, "google.pdf", m.Attachment.Name)
 	require.Equal(t, "http://ntfy.sh", m.Click)
 	require.Equal(t, 4, m.Priority)
+	require.True(t, m.Time > time.Now().Unix()+29*60)
+	require.True(t, m.Time < time.Now().Unix()+31*60)
+}
+
+func TestServer_PublishAsJSON_WithEmail(t *testing.T) {
+	mailer := &testMailer{}
+	s := newTestServer(t, newTestConfig(t))
+	s.mailer = mailer
+	body := `{"topic":"mytopic","message":"A message","email":"phil@example.com"}`
+	response := request(t, s, "PUT", "/", body, nil)
+	require.Equal(t, 200, response.Code)
+
+	m := toMessage(t, response.Body.String())
+	require.Equal(t, "mytopic", m.Topic)
+	require.Equal(t, "A message", m.Message)
+	require.Equal(t, 1, mailer.Count())
 }

 func TestServer_PublishAsJSON_Invalid(t *testing.T) {
--- a/server/types.go
+++ b/server/types.go
@@ -1,10 +1,8 @@
 package server

 import (
-	"errors"
 	"heckel.io/ntfy/util"
 	"net/http"
-	"strconv"
 	"time"
 )

@@ -22,11 +20,9 @@ const (

 // message represents a message published to a topic
 type message struct {
-	ID         string      `json:"id"`                // Random message ID
-	Time       int64       `json:"time"`              // Unix time in seconds
-	Updated    int64       `json:"updated,omitempty"` // Set if updated, unix time in seconds
-	Deleted    int64       `json:"deleted,omitempty"` // Set if deleted, unix time in seconds
-	Event      string      `json:"event"`             // One of the above
+	ID         string      `json:"id"`    // Random message ID
+	Time       int64       `json:"time"`  // Unix time in seconds
+	Event      string      `json:"event"` // One of the above
 	Topic      string      `json:"topic"`
 	Priority   int         `json:"priority,omitempty"`
 	Tags       []string    `json:"tags,omitempty"`
@@ -34,7 +30,7 @@ type message struct {
 	Attachment *attachment `json:"attachment,omitempty"`
 	Title      string      `json:"title,omitempty"`
 	Message    string      `json:"message,omitempty"`
-	Encoding   string      `json:"encoding,omitempty"` // Empty for raw UTF-8, or "base64" for encoded bytes
+	Encoding   string      `json:"encoding,omitempty"` // empty for raw UTF-8, or "base64" for encoded bytes
 }

 type attachment struct {
@@ -56,6 +52,8 @@ type publishMessage struct {
 	Click    string   `json:"click"`
 	Attach   string   `json:"attach"`
 	Filename string   `json:"filename"`
+	Email    string   `json:"email"`
+	Delay    string   `json:"delay"`
 }

 // messageEncoder is a function that knows how to encode a message
@@ -94,31 +92,11 @@ func validMessageID(s string) bool {
 	return util.ValidRandomString(s, messageIDLength)
 }

-func validUnixTimestamp(s string) bool {
-	_, err := toUnixTimestamp(s)
-	return err == nil
-}
-
-func toUnixTimestamp(s string) (int64, error) {
-	u, err := strconv.ParseInt(s, 10, 64)
-	if err != nil {
-		return 0, err
-	}
-	if u < 1000000000 || u > 3000000000 { // I know. It's practical. So relax ...
-		return 0, errors.New("invalid unix date")
-	}
-	return u, nil
-}
-
 type sinceMarker struct {
 	time time.Time
 	id   string
 }

-func newSince(id string, timestamp int64) sinceMarker {
-	return sinceMarker{time.Unix(timestamp, 0), id}
-}
-
 func newSinceTime(timestamp int64) sinceMarker {
 	return sinceMarker{time.Unix(timestamp, 0), ""}
 }
@@ -139,10 +117,6 @@ func (t sinceMarker) IsID() bool {
 	return t.id != ""
 }

-func (t sinceMarker) IsTime() bool {
-	return t.time.Unix() > 0
-}
-
 func (t sinceMarker) Time() time.Time {
 	return t.time
 }
--- a/util/util.go
+++ b/util/util.go
@@ -17,7 +17,7 @@ import (
 )

 const (
-	randomStringCharset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789" // Update updateTopicPathRegex if changed
+	randomStringCharset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
 )

 var (
--- a/web/public/static/css/home.css
+++ b/web/public/static/css/home.css
@@ -16,7 +16,7 @@ html {
 }

 a, a:visited {
-    color: #3a9784;
+    color: #338574;
 }

 a:hover {
@@ -114,7 +114,7 @@ code {
 }

 .anchor .anchorLink:hover {
-    color: #3a9784;
+    color: #338574;
    visibility: visible;
 }

@@ -221,7 +221,7 @@ figcaption {
 /* Header */

 #header {
-    background: #3a9784;
+    background: #338574;
    height: 130px;
 }

--- a/web/src/app/Poller.js
+++ b/web/src/app/Poller.js
@@ -56,6 +56,4 @@ class Poller {
 }

 const poller = new Poller();
-poller.startWorker();
-
 export default poller;
--- a/web/src/app/Pruner.js
+++ b/web/src/app/Pruner.js
@@ -1,7 +1,7 @@
 import prefs from "./Prefs";
 import subscriptionManager from "./SubscriptionManager";

-const delayMillis = 15000; // 15 seconds
+const delayMillis = 25000; // 25 seconds
 const intervalMillis = 1800000; // 30 minutes

 class Pruner {
@@ -35,6 +35,4 @@ class Pruner {
 }

 const pruner = new Pruner();
-pruner.startWorker();
-
 export default pruner;
--- a/web/src/app/SubscriptionManager.js
+++ b/web/src/app/SubscriptionManager.js
@@ -65,17 +65,13 @@ class SubscriptionManager {

    /** Adds notification, or returns false if it already exists */
    async addNotification(subscriptionId, notification) {
-        const existingNotification = await db.notifications.get(notification.id);
-        if (existingNotification) {
-            const upToDate = (existingNotification?.updated ?? 0) >= (notification.updated ?? 0);
-            if (upToDate) {
-                console.error(`[SubscriptionManager] up to date`, existingNotification, notification);
-                return false;
-            }
+        const exists = await db.notifications.get(notification.id);
+        if (exists) {
+            return false;
        }
        try {
            notification.new = 1; // New marker (used for bubble indicator); cannot be boolean; Dexie index limitation
-            await db.notifications.put({ ...notification, subscriptionId });
+            await db.notifications.add({ ...notification, subscriptionId }); // FIXME consider put() for double tab
            await db.subscriptions.update(subscriptionId, {
                last: notification.id
            });
--- a/web/src/components/App.js
+++ b/web/src/components/App.js
@@ -17,7 +17,7 @@ import {BrowserRouter, Outlet, Route, Routes, useOutletContext, useParams} from
 import {expandUrl} from "../app/utils";
 import ErrorBoundary from "./ErrorBoundary";
 import routes from "./routes";
-import {useAutoSubscribe, useConnectionListeners, useLocalStorageMigration} from "./hooks";
+import {useAutoSubscribe, useConnectionListeners, useBackgroundProcesses} from "./hooks";

 // TODO add drag and drop
 // TODO races when two tabs are open
@@ -67,7 +67,7 @@ const Layout = () => {
    });

    useConnectionListeners(subscriptions, users);
-    useLocalStorageMigration();
+    useBackgroundProcesses();
    useEffect(() => updateTitle(newNotificationsCount), [newNotificationsCount]);

    return (
--- a/web/src/components/hooks.js
+++ b/web/src/components/hooks.js
@@ -6,6 +6,7 @@ import notifier from "../app/Notifier";
 import routes from "./routes";
 import connectionManager from "../app/ConnectionManager";
 import poller from "../app/Poller";
+import pruner from "../app/Pruner";

 /**
 * Wire connectionManager and subscriptionManager so that subscriptions are updated when the connection
@@ -67,29 +68,13 @@ export const useAutoSubscribe = (subscriptions, selected) => {
 };

 /**
- * Migrate the 'topics' item in localStorage to the subscriptionManager. This is only done once to migrate away
- * from the old web UI.
+ * Start the poller and the pruner. This is done in a side effect as opposed to just in Pruner.js
+ * and Poller.js, because side effect imports are not a thing in JS, and "Optimize imports" cleans
+ * up "unused" imports. See https://github.com/binwiederhier/ntfy/issues/186.
 */
-export const useLocalStorageMigration = () => {
-    const [hasRun, setHasRun] = useState(false);
+export const useBackgroundProcesses = () => {
    useEffect(() => {
-        if (hasRun) {
-            return;
-        }
-        const topicsStr = localStorage.getItem("topics");
-        if (topicsStr) {
-            const topics = JSON.parse(topicsStr).filter(topic => topic !== "");
-            if (topics.length > 0) {
-                (async () => {
-                    for (const topic of topics) {
-                        const baseUrl = window.location.origin;
-                        const subscription = await subscriptionManager.add(baseUrl, topic);
-                        poller.pollInBackground(subscription); // Dangle!
-                    }
-                    localStorage.removeItem("topics");
-                })();
-            }
-        }
-        setHasRun(true);
+        poller.startWorker();
+        pruner.startWorker();
    }, []);
 }
Author	SHA1	Message	Date
Philipp Heckel	59ec2de8bd	Fix race in test	2022-03-30 14:37:42 -04:00
Philipp Heckel	d154d3936d	Bump version, release notes	2022-03-30 14:26:31 -04:00
Philipp Heckel	5125aac91c	Remove upx for arm64/armv7, more translation credits	2022-03-30 14:23:57 -04:00
Philipp Heckel	62512b7a1a	Change deprecation warning	2022-03-30 10:01:16 -04:00
Philipp Heckel	b67d9fc85d	Added missing 'delay' and 'email' params to publish as json	2022-03-29 15:40:26 -04:00
Philipp Heckel	59b341dfb8	Fix color of home page	2022-03-29 11:47:56 -04:00
Philipp Heckel	e2834a7c4d	Changelog	2022-03-29 10:44:12 -04:00
Philipp Heckel	2280031a80	Release notes, translations	2022-03-28 23:10:44 -04:00
Philipp Heckel	de1b97bbce	Merge branch 'main' of github.com:binwiederhier/ntfy into main	2022-03-28 14:10:24 -04:00
Philipp Heckel	3b4a4108e5	Release log	2022-03-28 14:10:14 -04:00
Philipp C. Heckel	dc1c0ddd4e	Update README.md	2022-03-28 11:07:05 -04:00
Philipp Heckel	182e21a9c3	Fix pruning bug in web app (closes #186 ), release notes, remove local storage migration	2022-03-27 09:20:25 -04:00
Philipp Heckel	d4fe2052c7	Release notes	2022-03-26 13:33:16 -04:00
Philipp Heckel	202051bbbf	Merge branch 'main' of github.com:binwiederhier/ntfy into main	2022-03-25 21:35:56 -04:00
Philipp Heckel	a693975526	Email docs and release notes	2022-03-25 21:35:40 -04:00
Philipp C. Heckel	4cd4e890fe	Update README.md	2022-03-25 18:56:22 -04:00
Philipp C. Heckel	5dc8031ec9	Update README.md	2022-03-25 18:54:40 -04:00
Philipp Heckel	03ad5dcff6	Add Allow-Origin: *, because YOLO	2022-03-25 17:17:24 -04:00
Philipp Heckel	5f508e1839	Tiny docs changes	2022-03-25 13:51:04 -04:00
Philipp C. Heckel	c5642799df	Merge pull request #178 from nickexyz/docs-noderedupdate Add Node-RED pictures and change ntfy URL to ntfy.sh	2022-03-25 13:32:05 -04:00
nickexyz	21fc1245eb	Update examples.md	2022-03-19 00:20:56 +00:00
Niclas Andersson	2511ba7627	Add Node-RED pictures and change ntfy URL to ntfy.sh	2022-03-19 01:16:02 +01:00