dearsky/numa
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 25 Wiki Activity

fix(dashboard): allowlist input erased by polling refresh #111

Merged
razvandimescu merged 1 commits from fix/allowlist-input-focus into main 2026-04-16 20:27:02 +08:00
Conversation 0 Commits 1 Files Changed 1 +1
razvandimescu commented 2026-04-16 20:12:44 +08:00 (Migrated from github.com)
Copy Link

Summary

Fixes #106.

  • The allowlist panel's renderAllowlist() replaced the entire section's innerHTML every 2 seconds (polling loop), including the <form> and <input>. If the user was mid-typing when the refresh fired, their text vanished — reported as "it would 'time out' and erase the entered text."
  • Fix: skip the re-render when allowDomainInput has focus. The list updates on the next refresh after the user submits or clicks away.
  • Note for the reporter: numa.toml already supports config-based allowlists under [blocking]: allowlist = ["tailscale.com"]. This pre-loads entries at startup without needing the dashboard.

Test plan

  • make all — fmt + clippy + audit + 285 tests pass
  • Open dashboard, start typing in allowlist input, wait >2s — text should persist
  • Submit a domain via the input — allowlist updates on next refresh cycle
  • Verify the existing polling refresh still updates the allowlist when the input is not focused
## Summary Fixes #106. - The allowlist panel's `renderAllowlist()` replaced the entire section's `innerHTML` every 2 seconds (polling loop), including the `<form>` and `<input>`. If the user was mid-typing when the refresh fired, their text vanished — reported as "it would 'time out' and erase the entered text." - Fix: skip the re-render when `allowDomainInput` has focus. The list updates on the next refresh after the user submits or clicks away. - Note for the reporter: `numa.toml` already supports config-based allowlists under `[blocking]`: `allowlist = ["tailscale.com"]`. This pre-loads entries at startup without needing the dashboard. ## Test plan - [x] `make all` — fmt + clippy + audit + 285 tests pass - [x] Open dashboard, start typing in allowlist input, wait >2s — text should persist - [x] Submit a domain via the input — allowlist updates on next refresh cycle - [x] Verify the existing polling refresh still updates the allowlist when the input is not focused
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 rust
Pull requests that update rust code
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/numa#111
Delete Branch "fix/allowlist-input-focus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?