dearsky/numa
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 25 Wiki Activity

feat: in-flight query coalescing with COALESCED path #20

Merged
razvandimescu merged 5 commits from feat/query-coalescing into main 2026-03-29 15:36:02 +08:00
Conversation 0 Commits 5 Files Changed 8 +586 -23
razvandimescu commented 2026-03-29 13:55:34 +08:00 (Migrated from github.com)
Copy Link

Summary

  • When multiple queries for the same (domain, qtype) arrive concurrently and miss cache, only the first triggers recursive resolution — others wait on a broadcast channel
  • Followers log as COALESCED (not RECURSIVE) in the query log and dashboard
  • InflightGuard (Drop impl) guarantees map cleanup on panic/task cancellation
  • Extracted acquire_inflight() function so disposition logic is testable independently
  • Dashboard: purple COALESCED tag, recursive and coalesced in path filter dropdown
  • Stats API includes coalesced count

Test plan

  • 11 tests: InflightGuard cleanup (3), acquire_inflight disposition (5), concurrent handle_query integration (3)
  • All disposition tests call real acquire_inflight(), not tokio primitives
  • make all passes (fmt, clippy, audit, build, 108 tests)
  • Manual: verified COALESCED label in dashboard for concurrent queries

🤖 Generated with Claude Code

## Summary - When multiple queries for the same `(domain, qtype)` arrive concurrently and miss cache, only the first triggers recursive resolution — others wait on a broadcast channel - Followers log as `COALESCED` (not `RECURSIVE`) in the query log and dashboard - `InflightGuard` (Drop impl) guarantees map cleanup on panic/task cancellation - Extracted `acquire_inflight()` function so disposition logic is testable independently - Dashboard: purple `COALESCED` tag, `recursive` and `coalesced` in path filter dropdown - Stats API includes `coalesced` count ## Test plan - [x] 11 tests: InflightGuard cleanup (3), acquire_inflight disposition (5), concurrent handle_query integration (3) - [x] All disposition tests call real `acquire_inflight()`, not tokio primitives - [x] `make all` passes (fmt, clippy, audit, build, 108 tests) - [x] Manual: verified COALESCED label in dashboard for concurrent queries 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 rust
Pull requests that update rust code
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/numa#20
Delete Branch "feat/query-coalescing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?