refactor: deduplicate query/record/sinkhole helpers #22

2026-03-29T18:34:51+08:00

razvandimescu commented

2026-03-29 18:34:51 +08:00

(Migrated from github.com)

Summary

Add DnsPacket::query(id, domain, qtype) constructor in packet.rs — replaces mock_query, make_query, and 4 inline query constructions across ctx.rs, forward.rs, recursive.rs, api.rs
Add record_to_addr() in recursive.rs — replaces 4 identical DnsRecord::A/AAAA → SocketAddr match blocks with .filter_map(record_to_addr)
Add sinkhole_record() in ctx.rs — consolidates localhost and blocklist A/AAAA branching into single function calls
Net: -30 lines, 3 fewer unused imports

Test plan

make all passes (fmt, clippy, audit, build, 111 tests)
Zero warnings
All existing tests validate identical behavior

🤖 Generated with Claude Code

## Summary - Add `DnsPacket::query(id, domain, qtype)` constructor in packet.rs — replaces `mock_query`, `make_query`, and 4 inline query constructions across ctx.rs, forward.rs, recursive.rs, api.rs - Add `record_to_addr()` in recursive.rs — replaces 4 identical `DnsRecord::A/AAAA → SocketAddr` match blocks with `.filter_map(record_to_addr)` - Add `sinkhole_record()` in ctx.rs — consolidates localhost and blocklist A/AAAA branching into single function calls - Net: -30 lines, 3 fewer unused imports ## Test plan - [x] `make all` passes (fmt, clippy, audit, build, 111 tests) - [x] Zero warnings - [x] All existing tests validate identical behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dearsky/numa#22