dearsky/pico-openpgp
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Fix conditional error resetting has_pw1 variable #17

Merged
imkuang merged 1 commits from fix_pw1-life-status into main 2024-07-15 21:12:26 +08:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
imkuang commented 2024-07-06 22:59:07 +08:00 (Migrated from github.com)
Copy Link

According to OpenPGP 3.4.1 specifications subsection 4.4.1:

PW status Bytes
1st byte: 00 = PW1 (no. 81) only valid for one PSO:CDS command
          01 = PW1 valid for several PSO:CDS commands

Therefore has_pw1 should be reset to false when the first byte of the PW status is 0 instead of 1.
This resulted in issue #16

According to OpenPGP 3.4.1 specifications subsection 4.4.1: ``` PW status Bytes 1st byte: 00 = PW1 (no. 81) only valid for one PSO:CDS command 01 = PW1 valid for several PSO:CDS commands ``` Therefore has_pw1 should be reset to false when the first byte of the PW status is 0 instead of 1. This resulted in issue #16
imkuang commented 2024-07-06 23:41:10 +08:00 (Migrated from github.com)
Copy Link

Not sure why the CI failed, but it doesn't seem too relevant to my commit?

Not sure why the CI failed, but it doesn't seem too relevant to my commit?
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/pico-openpgp#17
Delete Branch "fix_pw1-life-status"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?