refactor(rust-port): remove unused once-cell crate #58

2026-03-01T15:27:28+08:00

TropicalDog17 commented

2026-03-01 15:27:28 +08:00

(Migrated from github.com)

Summary of changes

Remove unused once-cell crate
Rebuild Cargo.lock by running cargo build --release

### Summary of changes - Remove unused `once-cell` crate - Rebuild `Cargo.lock` by running `cargo build --release`

👀 1

TropicalDog17 commented

2026-03-01 15:32:42 +08:00

(Migrated from github.com)

Hi can you review @ruvnet, this is my first time contributing to the project

ruvnet (Migrated from github.com) reviewed 2026-03-01 15:34:47 +08:00

ruvnet (Migrated from github.com) left a comment

Review

The once_cell removal is correct. Confirmed once_cell, Lazy, and OnceCell are not referenced anywhere in crates/wifi-densepose-nn/src/. The Cargo.toml change is a clean 1-line removal. Good catch.

However, the Cargo.lock regeneration introduces concerns:

The lockfile was regenerated with cargo build --release, which bumped ~30+ transitive dependencies to their latest versions and added 15 new crates that weren't in the previous lockfile:

getrandom 0.4.1, id-arena, leb128fmt, prettyplease, unicode-xid,
wasip3, wasm-bindgen-test-shared, wasm-encoder, wasm-metadata,
wasmparser, wit-bindgen-core, wit-bindgen-rust, wit-bindgen-rust-macro,
wit-component, wit-parser

These are transitive deps pulled in by version bumps (likely wasm-bindgen 0.2.100 → 0.2.103 bringing in WASI P3 / WIT component model support). No crates were removed.

The version bumps are individually fine (anyhow, chrono, clap, futures, etc. are all patch/minor bumps), but bundling them with a "remove unused crate" PR makes bisection harder if a regression surfaces.

Suggestion: Consider splitting into two commits or at minimum noting in the PR description that the lockfile includes transitive version bumps beyond the once_cell removal. This helps reviewers understand the scope.

Summary:

Cargo.toml change: approved — clean, correct
Cargo.lock: functionally fine but scope is larger than described (30+ version bumps, 15 new transitive crates)
No CI checks configured to validate the build — suggest running cargo test --workspace locally before merge

## Review **The `once_cell` removal is correct.** Confirmed `once_cell`, `Lazy`, and `OnceCell` are not referenced anywhere in `crates/wifi-densepose-nn/src/`. The `Cargo.toml` change is a clean 1-line removal. Good catch. **However, the `Cargo.lock` regeneration introduces concerns:** The lockfile was regenerated with `cargo build --release`, which bumped ~30+ transitive dependencies to their latest versions and **added 15 new crates** that weren't in the previous lockfile: ``` getrandom 0.4.1, id-arena, leb128fmt, prettyplease, unicode-xid, wasip3, wasm-bindgen-test-shared, wasm-encoder, wasm-metadata, wasmparser, wit-bindgen-core, wit-bindgen-rust, wit-bindgen-rust-macro, wit-component, wit-parser ``` These are transitive deps pulled in by version bumps (likely `wasm-bindgen` 0.2.100 → 0.2.103 bringing in WASI P3 / WIT component model support). No crates were removed. **The version bumps are individually fine** (anyhow, chrono, clap, futures, etc. are all patch/minor bumps), but bundling them with a "remove unused crate" PR makes bisection harder if a regression surfaces. **Suggestion:** Consider splitting into two commits or at minimum noting in the PR description that the lockfile includes transitive version bumps beyond the `once_cell` removal. This helps reviewers understand the scope. **Summary:** - Cargo.toml change: approved — clean, correct - Cargo.lock: functionally fine but scope is larger than described (30+ version bumps, 15 new transitive crates) - No CI checks configured to validate the build — suggest running `cargo test --workspace` locally before merge

TropicalDog17 commented

2026-03-01 15:36:53 +08:00

(Migrated from github.com)

@ruvnet this is because the Cargo.lock is outdated, so regeneration is needed so i can fully remove once_cell

@ruvnet this is because the Cargo.lock is outdated, so regeneration is needed so i can fully remove `once_cell`

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dearsky/wifi-densepose#58

refactor(rust-port): remove unused once-cell crate #58

Summary of changes

Review

refactor(rust-port): remove unused `once-cell` crate #58