dearsky/numa
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 25 Wiki Activity

fix: correct cache hit rate denominator #24

Merged
razvandimescu merged 1 commits from fix/cache-hit-rate-denominator into main 2026-03-30 05:17:40 +08:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
razvandimescu commented 2026-03-30 05:04:41 +08:00 (Migrated from github.com)
Copy Link

Summary

  • The cache hit rate was computed as cached / (cached + forwarded + local + overridden), excluding recursive and coalesced queries from the denominator
  • This inflated the displayed rate (e.g. 57.9%) far above the actual cache proportion shown in the resolution paths chart (20.9%)
  • Added recursive and coalesced to the denominator so the cache hit rate reflects the true ratio against all successfully resolved queries

Test plan

  • Open dashboard and verify cache hit rate is consistent with the Cached bar in resolution paths
  • Confirm rate excludes only blocked and error queries from the denominator

🤖 Generated with Claude Code

## Summary - The cache hit rate was computed as `cached / (cached + forwarded + local + overridden)`, excluding recursive and coalesced queries from the denominator - This inflated the displayed rate (e.g. 57.9%) far above the actual cache proportion shown in the resolution paths chart (20.9%) - Added `recursive` and `coalesced` to the denominator so the cache hit rate reflects the true ratio against all successfully resolved queries ## Test plan - [ ] Open dashboard and verify cache hit rate is consistent with the Cached bar in resolution paths - [ ] Confirm rate excludes only blocked and error queries from the denominator 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 rust
Pull requests that update rust code
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dearsky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dearsky/numa#24
Delete Branch "fix/cache-hit-rate-denominator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?